The "Last synced ..." time from the FxA menu is not updated accordingly
Categories
(Firefox :: Menus, defect, P1)
Tracking
()
People
(Reporter: ailea, Assigned: emmamalysz)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-hamburger-menu])
Attachments
(2 files)
Tested with:
Nightly 88.0a1 (2021-02-24)
Tested on:
Windows 10
Ubuntu 20.04
Preconditions:
In about:config, set browser.proton.appmenu.enabled = true
Steps:
- Launch firefox and sign in into FxA.
- Click on the sync now option and wait few seconds.
- Observe the Sync Now option.
Actual result:
The "Last synced ..." time from the FxA submenu always shows 1 second ago no matter how much time has passed from the last sync. When clicking on sync now, for a second, it shows the correct time.
Expected result:
The "Last synced ..." time should be updated accordingly.
Note: The issue is reproducible with and without Proton enabled.
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
I spoke with UX, and since the label does no auto-update, we're going to remove it.
The button should say "Sync now" without an icon, and when it is currently syncing, we update that text to "Syncing..." with the blue sync icon.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality
Comment 4•4 years ago
|
||
Backed out for causing failure at browser_sync.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/cd2a2a5321a7818e764a9f674e7427ec0c91bcbd
Failure log: https://treeherder.mozilla.org/logviewer?job_id=331437389&repo=autoland&lineNumber=2781
Comment 6•4 years ago
|
||
Backed out changeset 7692908f97e7 (Bug 1694678) for causing bc failures in browser_sync.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/fc9d862fb7bb7aed5d002d4f6888f43d82e34cde
Failure log: https://treeherder.mozilla.org/logviewer?job_id=331781222&repo=autoland&lineNumber=2300
Comment 7•4 years ago
|
||
There are also the following failures from this patch:
https://treeherder.mozilla.org/logviewer?job_id=331783115&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=331787769&repo=autoland
Comment 9•4 years ago
|
||
Backed out for failures on browser_sync.js
backout: https://hg.mozilla.org/integration/autoland/rev/3d514b514408ebeec5a009b400c0c0a02742e9a6
failure log: https://treeherder.mozilla.org/logviewer?job_id=331856071&repo=autoland&lineNumber=3325
[task 2021-03-03T07:42:53.451Z] 07:42:53 INFO - TEST-PASS | browser/base/content/test/sync/browser_sync.js | PanelUI-fxa-menu-setup-sync-button is hidden -
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - Buffered messages finished
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_sync.js | expected avatar URL to be url("chrome://browser/skin/fxa/avatar.svg"), got none -
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - Stack trace:
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_sync.js:checkFxAAvatar:584
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_sync.js:test_ui_state_signedin:161
[task 2021-03-03T07:42:53.454Z] 07:42:53 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-03-03T07:42:53.455Z] 07:42:53 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_sync.js | expected avatar URL to be url("chrome://browser/skin/fxa/avatar.svg"), got none -
[task 2021-03-03T07:42:53.455Z] 07:42:53 INFO - Stack trace:
[task 2021-03-03T07:42:53.456Z] 07:42:53 INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-03-03T07:42:53.456Z] 07:42:53 INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_sync.js:checkFxAAvatar:584
[task 2021-03-03T07:42:53.456Z] 07:42:53 INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_sync.js:test_ui_state_signedin:161
[task 2021-03-03T07:42:53.457Z] 07:42:53 INFO - GECKO(1855) | [Parent 1855, Main Thread] WARNING: NS_ENSURE_TRUE(weakFrame.IsAlive()) failed: file /builds/worker/checkouts/gecko/layout/xul/nsXULPopupManager.cpp:1068
[task 2021-03-03T07:42:53.458Z] 07:42:53 INFO - GECKO(1855) | [Parent 1855, Main Thread] WARNING: '!mPresContext', file /builds/worker/checkouts/gecko/dom/events/UIEvent.cpp:138
[task 2021-03-03T07:42:53.458Z] 07:42:53 INFO - TEST-PASS | browser/base/content/test/sync/browser_sync.js | fxa label has the right value -
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
bugherder |
Reporter | ||
Comment 12•4 years ago
|
||
Verified - Fixed in latest Nightly 88.0a1 (build id: 20210315214853) both with proton pref on and off, using Windows 10, Ubuntu 18.04 and MacOS 10.15.
Assignee | ||
Updated•4 years ago
|
Description
•