Closed Bug 1694678 Opened 4 years ago Closed 4 years ago

The "Last synced ..." time from the FxA menu is not updated accordingly

Categories

(Firefox :: Menus, defect, P1)

defect

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- verified

People

(Reporter: ailea, Assigned: emmamalysz)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-hamburger-menu])

Attachments

(2 files)

Attached video 2021-02-24_17h19_32.mp4 (deleted) —

Tested with:

Nightly 88.0a1 (2021-02-24)

Tested on:

Windows 10
Ubuntu 20.04

Preconditions:

In about:config, set browser.proton.appmenu.enabled = true

Steps:

  1. Launch firefox and sign in into FxA.
  2. Click on the sync now option and wait few seconds.
  3. Observe the Sync Now option.

Actual result:

The "Last synced ..." time from the FxA submenu always shows 1 second ago no matter how much time has passed from the last sync. When clicking on sync now, for a second, it shows the correct time.

Expected result:

The "Last synced ..." time should be updated accordingly.

Note: The issue is reproducible with and without Proton enabled.

I spoke with UX, and since the label does no auto-update, we're going to remove it.

The button should say "Sync now" without an icon, and when it is currently syncing, we update that text to "Syncing..." with the blue sync icon.

Assignee: nobody → emalysz
Priority: -- → P1

This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/962540b712f9 update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7692908f97e7 update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/44ff4cb38ce1 update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley

Backed out for failures on browser_sync.js

backout: https://hg.mozilla.org/integration/autoland/rev/3d514b514408ebeec5a009b400c0c0a02742e9a6

push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=I7pJsz82Q8KWpspGg0MMxA.0&revision=44ff4cb38ce187b7f0f5950b32f2b72c8d200c24&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=331856071&repo=autoland&lineNumber=3325

[task 2021-03-03T07:42:53.451Z] 07:42:53 INFO - TEST-PASS | browser/base/content/test/sync/browser_sync.js | PanelUI-fxa-menu-setup-sync-button is hidden -
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - Buffered messages finished
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_sync.js | expected avatar URL to be url("chrome://browser/skin/fxa/avatar.svg"), got none -
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - Stack trace:
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_sync.js:checkFxAAvatar:584
[task 2021-03-03T07:42:53.453Z] 07:42:53 INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_sync.js:test_ui_state_signedin:161
[task 2021-03-03T07:42:53.454Z] 07:42:53 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-03-03T07:42:53.455Z] 07:42:53 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_sync.js | expected avatar URL to be url("chrome://browser/skin/fxa/avatar.svg"), got none -
[task 2021-03-03T07:42:53.455Z] 07:42:53 INFO - Stack trace:
[task 2021-03-03T07:42:53.456Z] 07:42:53 INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-03-03T07:42:53.456Z] 07:42:53 INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_sync.js:checkFxAAvatar:584
[task 2021-03-03T07:42:53.456Z] 07:42:53 INFO - chrome://mochitests/content/browser/browser/base/content/test/sync/browser_sync.js:test_ui_state_signedin:161
[task 2021-03-03T07:42:53.457Z] 07:42:53 INFO - GECKO(1855) | [Parent 1855, Main Thread] WARNING: NS_ENSURE_TRUE(weakFrame.IsAlive()) failed: file /builds/worker/checkouts/gecko/layout/xul/nsXULPopupManager.cpp:1068
[task 2021-03-03T07:42:53.458Z] 07:42:53 INFO - GECKO(1855) | [Parent 1855, Main Thread] WARNING: '!mPresContext', file /builds/worker/checkouts/gecko/dom/events/UIEvent.cpp:138
[task 2021-03-03T07:42:53.458Z] 07:42:53 INFO - TEST-PASS | browser/base/content/test/sync/browser_sync.js | fxa label has the right value -

Flags: needinfo?(emalysz)
Flags: needinfo?(emalysz)
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e2fdbe6d3f2 update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Regressions: 1698492

Verified - Fixed in latest Nightly 88.0a1 (build id: 20210315214853) both with proton pref on and off, using Windows 10, Ubuntu 18.04 and MacOS 10.15.

Status: RESOLVED → VERIFIED
Flags: needinfo?(emalysz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: