Closed Bug 1694680 Opened 4 years ago Closed 4 years ago

Fix qcms_data_create_rgb_with_gamma.

Categories

(Core :: Graphics: Color Management, defect)

Product:
Core
Component:
Graphics: Color Management
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

Bug 1694680 - Fix qcms_data_create_rgb_with_gamma.
(deleted), text/x-phabricator-request
Details

This fixes a number of problems:

  1. The check around get_rgb_colorants was inverted. This caused us to
    only continue if the colorants were wrong.

  2. get_rgb_colorants can just return the Matrix instead of taking
    a reference to it.

  3. The OOBs checks in write_u32 and write_u16 had their conditions
    inverted.

  4. No tests

This fixes a number of problems:

  1. The check around get_rgb_colorants was inverted. This caused us to
    only continue if the colorants were wrong.

  2. get_rgb_colorants can just return the Matrix instead of taking
    a reference to it.

  3. No tests

Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa296c490720 Fix qcms_data_create_rgb_with_gamma.

https://hg.mozilla.org/mozilla-central/rev/fa296c490720

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Regressions: 1696819
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: