Part of hamburger menu icon is overlapped if the window is shrinked to its minimum width
Categories
(Firefox :: Toolbars and Customization, defect, P2)
Tracking
()
People
(Reporter: csasca, Assigned: bigiri)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-toolbar])
Attachments
(2 files)
Affected versions
- Firefox 88.0a1
Affected platforms
- Windows 10
- macOS 11.2.2
- Ubuntu 20.04
Steps to reproduce
- Launch Firefox
- Grab the browser from a margin and shrink it to its minimum witdh
Expected result
- Hamburger menu icon is fully visible
Actual result
- Part of hamburger menu icon is overlapped
Regression range
- Introduced with new toolbar
Additional notes
- The issue can be seen in the following attachment
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 1•4 years ago
|
||
(In reply to Catalin Sasca, QA [:csasca] from comment #0)
- The issue can be seen in the following attachment
Please put this directly on the bug.
Reporter | ||
Comment 2•4 years ago
|
||
Can't upload it directly as it has ~40mb, it's a macOS screencast. I can attach an image with the issue directly, if it helps.
Comment 3•4 years ago
|
||
(In reply to Catalin Sasca, QA [:csasca] from comment #2)
Can't upload it directly as it has ~40mb, it's a macOS screencast. I can attach an image with the issue directly, if it helps.
Then please remove viewer restrictions from the gdoc.
Reporter | ||
Comment 4•4 years ago
|
||
Ok, the screencast should work now. Thanks!
Comment 5•4 years ago
|
||
Emma, from mozregression it seems like the removal of the home button in bug 1686523 broke this (though it's hard to be sure because starting with browser.proton.enabled
and browser.proton.toolbar.enabled
results in a busted browser for a few days, fixed in bug 1692351 but makes it tricky to know what's the exact root cause with mozregression -- maybe the bustedness caused by that is different from what's described in this bug, even if the result is similar). Can you take a look?
Comment 7•4 years ago
|
||
I think Bug 1686530 is more likely to have caused this, as this is reproducible with or without the home button. It looks like we have the padding-inline-end
set for the menu button (https://searchfox.org/mozilla-central/rev/63fcc3f1a2cc73488d8986f4cf91fce2cd4b7564/browser/themes/shared/toolbarbuttons.inc.css#148-151) but it's still cut off.
Going to redirect ni? to Bernard who worked on Bug 1686530
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 8•4 years ago
|
||
Is this still an issue or has it been fixed? I'm not seeing it when I build it on MacOS.
Assignee | ||
Comment 9•4 years ago
|
||
Please disregard my prior comment, Blake just showed me how to reproduce this.
Assignee | ||
Comment 10•4 years ago
|
||
Reduced the width of the url nav bar when the window is shrunk to make space for the hamburger menu in proton.
Assignee | ||
Comment 11•4 years ago
|
||
Please note that reproducing this bug requires that you add multiple buttons to the toolbar.
Comment 12•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 13•4 years ago
|
||
Bernard: Please don't close bugs when you autoland. They are not fixed until the fix is merged to m-c, and then a bot will mark them as fixed and set other appropriate flags like the release tracking ones.
Comment 14•4 years ago
|
||
bugherder |
Reporter | ||
Comment 15•4 years ago
|
||
Tried verifying this issue with a treeherder build, seems that it still is a bit overlapped attachment but happening only on macOS and Ubuntu now, while Windows 10 seems to be ok. Should we open a new bug for it?
Updated•4 years ago
|
Description
•