Closed
Bug 1695349
Opened 4 years ago
Closed 4 years ago
Remove endian handling from XDR
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
XDR uses little-endian for XDRState::codeUint* APIs, but now we use XDRState::{codeBytes,borrowedData} for most data in Stencil XDR, the XDR buffer isn't fully little-endian, but mix of little/native endian.
For simplicity, it would be better just stop converting to little-endian, but directly use native-endian.
this doesn't affect little-endian arch, and will reduce extra swap operation on big-endian arch.
(note that bytecode itself still uses little endian)
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D112495
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D112496
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/5d35704fb35d
Part 1: Remove endian handling from XDRState methods. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e2ecb632ffd1
Part 2: Rename XDRState::peekRawUint32 to XDRState::peekUint32. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f56fb92a6939
Part 3: Remove endian handling from ObjLiteralStencil. r=tcampbell
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5d35704fb35d
https://hg.mozilla.org/mozilla-central/rev/e2ecb632ffd1
https://hg.mozilla.org/mozilla-central/rev/f56fb92a6939
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•