Closed Bug 1695518 Opened 4 years ago Closed 4 years ago

"Sync and Save Data" remains in proton AppMenu when identity.fxaccounts.enabled is false

Categories

(Firefox :: Menus, defect, P5)

Firefox 88
Desktop
All
defect

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- disabled

People

(Reporter: aoia7rz7l, Assigned: zbraniecki)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: helpwanted, regression, Whiteboard: [proton-hamburger-menu])

Attachments

(1 file)

Tested in 88.0a1(2021-02-25) BuildID 20210225215504.

STR:

  1. Set identity.fxaccounts.enabled to false and restart Firefox.
  2. "Sign in to Firefox" is hidden in photon AppMenu (Expected Behavior; separator may remain due to lazy load issue Bug 1667869)
  3. Set browser.proton.appmenu.enabled to true and restart Firefox.

Expected Behavior:
"Sync and Save Data" menu item and the colored separator should disappear from proton AppMenu when when identity.fxaccounts.enabled is false.

Actual Behavior:
Text within the "Sign-In" button is hidden but "Sync and Save Data" remains in proton AppMenu. Button is still clickable and functional.

The Bugbug bot thinks this bug should belong to the 'Firefox::Firefox Accounts' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Firefox Accounts
Status: UNCONFIRMED → NEW
Component: Firefox Accounts → Menus
Ever confirmed: true
Keywords: regression
OS: Unspecified → All
Regressed by: 1690131
Hardware: Unspecified → Desktop
Has Regression Range: --- → yes
Whiteboard: [proton-hamburger-menu]
Severity: -- → S4
Keywords: helpwanted
Priority: -- → P5
Assignee: nobody → zbraniecki
Status: NEW → ASSIGNED
Pushed by zbraniecki@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38607d980ba7 Disable Save and Sync Data in App Menu is fxa is disabled. r=emalysz
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Reproduced the issue in Nightly 88.0a1.
Verified - Fixed in latest Nightly 90.0a1(2021-04-20) and Beta 89.0b2. The "Sync and Save Data" is not displayed anymore in the App Menu while identity.fxaccounts.enabled is set to false. Verified on Windows 10 and Ubuntu 20.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: