Closed
Bug 1695588
Opened 4 years ago
Closed 4 years ago
When a new alias is set, only notify the engine has changed if the alias is different
Categories
(Firefox :: Search, defect, P2)
Firefox
Search
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Currently if we attempt to set the alias of an engine to the same value, we'll notify that the engine has changed.
I don't think we should notify - there's no reason for it, and it means that we get extra notifications when removing an application provided engine that we possibly don't need. It also complicates tests.
|
Assignee | |
Comment 1•4 years ago
|
||
It also means we're not rewriting the search settings file if the user edits the alias in preferences, and then presses enter with no changes.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ebfd2d11f33
When a new search engine alias is set, only notify the engine has changed if the alias is different. r=mak
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•