Closed
Bug 1695694
Opened 4 years ago
Closed 4 years ago
[Proton] Windows 10 Context menu separator colours need updating
Categories
(Firefox :: Menus, defect, P2)
Tracking
()
VERIFIED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | verified |
People
(Reporter: emilghitta, Assigned: mtigley)
References
(Blocks 2 open bugs)
Details
(Keywords: helpwanted, Whiteboard: [proton-context-menus])
Attachments
(2 files)
separator-proton.png
Affected versions
- Firefox 88.0a1 (BuildId:20210301093612)
Affected platforms
- Windows 10 64bit
Unaffected platforms
- macOS 10.14
- Ubuntu 20.04
Preconditions
- Set your monitor settings to high contrast values (~90%)
Steps to reproduce
- Launch Firefox.
- Enable proton context menu.
- Right click on the address bar.
Expected result
- The separator is visible.
Actual result
- The separator is barely visible.
Regression Range
- I don’t think that this is a regression.
Notes
- For further information regarding this issue please observe the attached screenshots
- This issue is only reproducible with proton enabled.
|
||
Comment 1•4 years ago
|
||
The design has #52525E for dark mode and #E0E0E6 for light mode.
Blocks: 1682522
Severity: S4 → S3
Keywords: helpwanted
Priority: -- → P3
Summary: Context menu’s separator is barely visible with high contrast values → [Proton] Windows 10 Context menu separator colours need updating
|
|
||
Comment 2•4 years ago
|
||
(In reply to :Gijs (he/him) from comment #1)
The design has
#52525Efor dark mode and#E0E0E6for light mode.
Looks like this is basically the menuitem-hover-background-color variable, with the dark mode one still needing updates to match the new dark theme spec.
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-359
|
||
Updated•4 years ago
|
Has STR: --- → yes
|
|
||
Updated•4 years ago
|
Priority: P3 → P2
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•4 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dda8cf18710c
Update context menu separator colors on Windows. r=Gijs
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
|
||
Comment 6•4 years ago
|
||
Verified that this is fixed on Windows 10 using latest Nightly 88.0a1.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•