Closed
Bug 1695917
Opened 4 years ago
Closed 4 years ago
In DnsAndConnectSocket::TransportSetup::ResolveHost(), we should not always dispatch a sync runnable to main thread
Categories
(Core :: Networking: HTTP, defect, P2)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
88 Branch
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: kershaw, Assigned: kershaw)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert, Whiteboard: [necko-triaged])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
DnsAndConnectSocket::TransportSetup::ResolveHost should be always be called on socket thread, so this means we always dispatch a sync runnable to main thread just for getting the DNS service.
Assignee | ||
Comment 1•4 years ago
|
||
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7322919d3bbc
Optimize the way we get DNS service in DnsAndConnectSocket r=necko-reviewers,dragana
Comment 3•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Comment 4•4 years ago
|
||
== Change summary for alert #29179 (as of Wed, 10 Mar 2021 19:28:24 GMT) ==
Improvements:
Ratio | Suite | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|---|
10% | tp5o | windows10-64-shippable-qr | e10s stylo webrender | 274.94 -> 246.24 | |
10% | tp5o | windows10-64-shippable | e10s stylo | 295.20 -> 266.32 | |
9% | tp5o | windows10-64-shippable-qr | e10s stylo webrender-sw | 269.01 -> 243.70 | |
9% | tp5o | responsiveness | linux64-shippable-qr | e10s stylo webrender | 2.89 -> 2.63 |
9% | tp5o | responsiveness | linux64-shippable | e10s stylo | 1.90 -> 1.73 |
5% | tp5o | macosx1015-64-shippable-qr | e10s stylo webrender | 185.73 -> 175.79 | |
5% | tp5o | macosx1015-64-shippable-qr | e10s stylo webrender-sw | 185.80 -> 176.18 | |
4% | tp5o_webext | windows10-64-shippable-qr | e10s stylo webrender | 348.89 -> 335.16 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29179
Updated•4 years ago
|
Keywords: perf-alert
Assignee | ||
Comment 5•4 years ago
|
||
I think this improvement is expected.
You need to log in
before you can comment on or make changes to this bug.
Description
•