Closed Bug 1696437 (android-nnt) Opened 4 years ago Closed 4 years ago

Use the new non-native theme on Android too.

Categories

(Core Graveyard :: Widget: Android, defect)

Product:
Core Graveyard
Component:
Widget: Android
Type:
defect

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(3 files, 3 obsolete files)

Bug 1696437 - Annotate more Android+nnt tests. r=mstange
(deleted), text/x-phabricator-request
Details
Bug 1696437 - Fix bad assumptions in baseline-alignment-and-overflow.tentative.html. r=mstange
(deleted), text/x-phabricator-request
Details
Bug 1696437 - Enable non-native theme on Android Nightly. r=mstange
(deleted), text/x-phabricator-request
Details
No description provided.
Alias: android-nnt
Attached file Bug 1696437 - Annotate more Android+nnt tests. (obsolete) (deleted) —

Dialog-form-submission was hitting a rounding error because of a weird
DPI caused by the viewport scaling. The rest are simple annotation tweaks.

The file button inherits the font-size of the file input, so that needs
fixing.

The checkbox baseline was also the other thing that was wrong, and that allows
us to remove the sketchy allowedDelta.

Depends on D107226

Last platform that remains! Will send fixes for the couple failures in a sec.

Depends on D107227

Dialog-form-submission was hitting a rounding error because of a weird
DPI caused by the viewport scaling. The rest are simple annotation tweaks.

The file button inherits the font-size of the file input, so that needs fixing.

Related HTML spec PR: https://github.com/whatwg/html/pull/6447

The checkbox baseline was also the other thing that was wrong, and that allows
us to remove the sketchy allowedDelta.

Depends on D107229

Last platform that remains! Will send fixes for the couple failures in a sec.

Depends on D107230

Attachment #9206921 - Attachment is obsolete: true
Attachment #9206920 - Attachment is obsolete: true
Attachment #9206922 - Attachment is obsolete: true
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a4b46617522 Annotate more Android+nnt tests. r=mstange https://hg.mozilla.org/integration/autoland/rev/c45afb640afd Fix bad assumptions in baseline-alignment-and-overflow.tentative.html. r=mstange https://hg.mozilla.org/integration/autoland/rev/cfedda4b91e1 Enable non-native theme on Android Nightly. r=mstange
Regressions: 1696631
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27996 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: