Emit target-destroyed-form for all cases where we used to emit tabDetached
Categories
(DevTools :: Framework, enhancement)
Tracking
(Fission Milestone:M7, firefox88 fixed)
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(3 files)
In order to be able to complete bug 1631451 and remove tabDetached in favor of target-destroyed-form, we ought to emit target-destroyed-form for all cases where we currently emit tabDetached.
When removing tabDetached I identified two cases:
- top level tab target, when doing a process switch is missing such event
- content process targets are used to have tabDetached on teardown (this isn't something we do for all targets)
Assignee | ||
Comment 1•4 years ago
|
||
This is a workaround, until the top level target uses the JSWindowActor codepath.
This will help get rid of tabDetached in favor of target-destroyed-form.
Assignee | ||
Comment 2•4 years ago
|
||
There was a typo in item.watcher != watcher
...
Assignee | ||
Comment 3•4 years ago
|
||
We are currently receiving tabDetached for content process targets
when we destroy them via:
Services.ppmm.broadcastAsyncMessage("debug:destroy-process-script")
done from process-helper and we stop watching for process targets.
Tests now depends on this behavior.
So I'm trying to replicate this behavior in order to later get rid of tabDetached
in favor of target-destroyed-form.
Assignee | ||
Comment 4•4 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4476f926c4f [devtools] Notify about top level target destruction via watcher's target-destroyed-form. r=nchevobbe,jdescottes https://hg.mozilla.org/integration/autoland/rev/63799ea4103b [devtools] Properly close transports for content process targets. r=nchevobbe,jdescottes https://hg.mozilla.org/integration/autoland/rev/1acce6920635 [devtools] Notify about content process target destruction via watcher's target-destroyed-form. r=nchevobbe,jdescottes
Comment 6•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c4476f926c4f
https://hg.mozilla.org/mozilla-central/rev/63799ea4103b
https://hg.mozilla.org/mozilla-central/rev/1acce6920635
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Description
•