Modal styles when RDM is enabled need to be fixed
Categories
(Toolkit Graveyard :: Notifications and Alerts, defect, P1)
Tracking
(firefox-esr78 unaffected, firefox86 unaffected, firefox87 unaffected, firefox88 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox86 | --- | unaffected |
| firefox87 | --- | unaffected |
| firefox88 | --- | fixed |
People
(Reporter: mtigley, Assigned: mtigley)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [proton-modals])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The new modal styles introduced in Bug 1693277 don't work well with Responsive Design Mode. This is because when RDM is enabled, we set position: fixed on the dialogStack in https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/devtools/client/responsive/responsive-browser.css#132 and it ends up messing with the modal's sizing.
One approach is to use a resize observer on the dialogStack to set the height of the modal. This is actually similar to what we're doing for the RDM toolbar https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/devtools/client/responsive/ui.js#241-245.
We should try exploring a more CSS-oriented (with maybe a little help from JS) to fix this issue. But at least we have a fallback if this proves too difficult.
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Comment 1•4 years ago
|
||
Set release status flags based on info from the regressing bug 1693277
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
|
||
Updated•1 year ago
|
Description
•