Closed Bug 1696768 Opened 4 years ago Closed 4 years ago

Remove "marionette.contentListener" and don't default to true for "marionette.debugging.clicktostart" when debugging

Categories

(Remote Protocol :: Marionette, task, P3)

Default
task

Tracking

(firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(2 files)

The preference is no longer needed. Necessary breakpoint could be set in the Marionette code before starting Firefox by adding debugger statements. Right now it's only annoying to have to click away those modal dialogs.

Actually there is also marionette.contentListener, which is marked as deprecated:

https://searchfox.org/mozilla-central/rev/44695ef057e422a8d6c6056972bdf32766c36187/modules/libpref/init/all.js#4556-4558

Both got added via bug 1456050 and don't seem to be needed anymore.

Summary: Remove marionette.debugging.clicktostart preference → Remove marionette.debugging.clicktostart and marionette.contentListener preferences

Actually it would be good to keep the marionette.debugging.clicktostart preference but don't set it implicitly to true when --jsdebugger is passed. That would still allow users of Selenium / geckodriver to debug a Marionette session without having to download the code first.

Summary: Remove marionette.debugging.clicktostart and marionette.contentListener preferences → Remove "marionette.contentListener" and don't default to true for "marionette.debugging.clicktostart" when debugging
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P3

Always getting a user prompt shown when debugging code in Marionette
is disturbing. Given that we usually use the "debugger;" statement
anyway, this prompt will not be useful by default.

But we should keep it to actually allow users of Marionette and
geckodriver to run a debug session without having to modify the
code first.

Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e9fa8d73a47 [marionette] Don't enable "marionette.debugging.clicktostart" by default when --jsdebugger is used. r=marionette-reviewers,webdriver-reviewers,jdescottes,jgraham https://hg.mozilla.org/integration/autoland/rev/fdae009d0b38 [marionette] Remove unused "marionette.contentListener" preference. r=marionette-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: