Closed Bug 1696842 Opened 4 years ago Closed 3 years ago

Establish raster roots for more picture composite modes

Categories

(Core :: Graphics: WebRender, task)

Product:
Core
Component:
Graphics: WebRender
Type:
task

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: gw, Assigned: gw)

References

Details

(Keywords: perf-alert)

Attachments

(2 obsolete files)

No description provided.

Add MixBlend and ComponentTransfer to the picture composite modes that
unconditionally establish a raster root.

All the known bugs with the raster root code have been fixed, so let's
start incrementally enabling raster roots for more picture modes, and
fix any regressions that come from these before making raster roots
the default for all surfaces.

Assignee: nobody → gwatson
Status: NEW → ASSIGNED
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af65c3578782 Establish raster roots for more picture composite modes. r=gfx-reviewers,lsalzman

https://hg.mozilla.org/mozilla-central/rev/af65c3578782

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Regressions: 1697558

Backed out changeset af65c3578782 (bug 1696842) as requested by dev. CLOSED TREE

Backout:
https://hg.mozilla.org/integration/autoland/rev/5740bf7162a0ce70977923a1f0949dd0255de5ad

Status: RESOLVED → REOPENED
status-firefox88: fixed → ---
Resolution: FIXED → ---
Target Milestone: 88 Branch → ---

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:gw, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(lsalzman)
Flags: needinfo?(gwatson)

It depends on me finding time to fix #1697558 before re-landing this.

Depends on: 1697558
Flags: needinfo?(gwatson)
Flags: needinfo?(lsalzman)
Attachment #9207350 - Attachment is obsolete: true

Add MixBlend and ComponentTransfer to the picture composite modes that
unconditionally establish a raster root.

All the known bugs with the raster root code have been fixed, so let's
start incrementally enabling raster roots for more picture modes, and
fix any regressions that come from these before making raster roots
the default for all surfaces.

Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28c7b58df8e4 Establish raster roots for more picture composite modes r=gfx-reviewers,lsalzman

https://hg.mozilla.org/mozilla-central/rev/28c7b58df8e4

Status: REOPENED → RESOLVED
Closed: 4 years ago → 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Regressions: 1720666

Backed out for causing pref regressions.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9f2dedfc1c269c9e75623180ba515cf6549b9163

Status: RESOLVED → REOPENED
status-firefox92: fixed → ---
Resolution: FIXED → ---
Target Milestone: 92 Branch → ---
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/042a934005b6 Establish raster roots for more picture composite modes r=gfx-reviewers,lsalzman

https://hg.mozilla.org/mozilla-central/rev/042a934005b6

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

(In reply to Pulsebot from comment #13)

Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/042a934005b6
Establish raster roots for more picture composite modes
r=gfx-reviewers,lsalzman

== Change summary for alert #32128 (as of Wed, 27 Oct 2021 08:15:25 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
104% google-slides LastVisualChange macosx1014-64-shippable-qr warm webrender 2,966.67 -> 6,053.33
90% google-slides LastVisualChange macosx1014-64-shippable-qr cold webrender 5,106.67 -> 9,716.67
78% google-slides LastVisualChange macosx1014-64-shippable-qr fission warm webrender 2,966.67 -> 5,266.67
69% google-slides ContentfulSpeedIndex macosx1014-64-shippable-qr warm webrender 960.83 -> 1,621.67
66% google-slides LastVisualChange macosx1014-64-shippable-qr cold fission webrender 5,186.67 -> 8,596.67
60% google-slides ContentfulSpeedIndex macosx1014-64-shippable-qr fission warm webrender 970.25 -> 1,552.08
58% google-slides SpeedIndex macosx1014-64-shippable-qr warm webrender 830.33 -> 1,308.25
58% google-slides dcf macosx1014-64-shippable-qr warm webrender 1,045.25 -> 1,646.33
57% google-slides PerceptualSpeedIndex macosx1014-64-shippable-qr warm webrender 847.33 -> 1,330.92
48% google-slides SpeedIndex macosx1014-64-shippable-qr fission warm webrender 837.92 -> 1,240.58
... ... ... ... ...
7% google-slides PerceptualSpeedIndex macosx1015-64-shippable-qr cold fission webrender 1,130.46 -> 1,208.00
6% google-slides ContentfulSpeedIndex macosx1015-64-shippable-qr cold fission webrender 1,298.17 -> 1,377.17
6% instagram dcf macosx1014-64-shippable-qr cold fission webrender 772.25 -> 817.79
4% instagram SpeedIndex macosx1015-64-shippable-qr cold webrender 1,235.88 -> 1,289.42
3% linkedin dcf linux1804-64-shippable-qr cold webrender 1,267.12 -> 1,309.88

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
11% nytimes LastVisualChange linux1804-64-shippable-qr warm webrender 2,110.00 -> 1,876.67
10% reddit ContentfulSpeedIndex macosx1015-64-shippable-qr warm webrender 542.67 -> 486.50
8% reddit PerceptualSpeedIndex macosx1015-64-shippable-qr warm webrender 568.96 -> 524.58
7% fandom LastVisualChange linux1804-64-shippable-qr fission warm webrender 605.00 -> 560.00
5% fandom PerceptualSpeedIndex linux1804-64-shippable-qr fission warm webrender 410.92 -> 388.58
... ... ... ... ...
4% outlook ContentfulSpeedIndex macosx1015-64-shippable-qr cold webrender 1,961.75 -> 1,892.17

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32128

Backed out for causing bug 1738241

Backout link: https://hg.mozilla.org/integration/autoland/rev/573c31f23a806b63ad47bd12bfc265401e48e813

Status: RESOLVED → REOPENED
status-firefox95: fixed → ---
Flags: needinfo?(gwatson)
Resolution: FIXED → ---
Target Milestone: 95 Branch → ---

Backed out for performance regression, looks like some of the sites above use component transfer and this seems to regress with the patch (not sure why yet).

Flags: needinfo?(gwatson)

(In reply to Sandor Molnar from comment #16)

Backed out for causing bug 1738241

Backout link: https://hg.mozilla.org/integration/autoland/rev/573c31f23a806b63ad47bd12bfc265401e48e813

== Change summary for alert #32206 (as of Mon, 01 Nov 2021 09:39:46 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
46% JS linux1804-64-shippable-qr tp6 197,559,789.19 -> 289,219,941.66

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
32% Heap Unclassified linux1804-64-shippable-qr tp6 318,905,743.21 -> 218,014,565.39
7% Explicit Memory linux1804-64-shippable-qr tp6 925,162,969.81 -> 860,972,063.45
6% Resident Memory linux1804-64-shippable-qr tp6 1,327,869,237.11 -> 1,250,776,653.25
5% Resident Memory linux1804-64-shippable-qr tp6 1,327,709,411.94 -> 1,265,411,331.63

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32206

== Change summary for alert #32195 (as of Mon, 01 Nov 2021 03:42:54 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
31% google-slides FirstVisualChange windows10-64-shippable-qr fission warm webrender 365.00 -> 251.17
31% google-slides dcf macosx1014-64-shippable-qr warm webrender 1,564.15 -> 1,084.58
29% google-slides FirstVisualChange windows10-64-shippable-qr warm webrender 362.25 -> 256.33
26% google-slides LastVisualChange linux1804-64-shippable-qr cold webrender 4,640.00 -> 3,443.33
26% google-slides PerceptualSpeedIndex windows10-64-shippable-qr fission warm webrender 829.67 -> 615.92
... ... ... ... ...
7% google-slides loadtime windows10-64-shippable-qr fission warm webrender 1,470.48 -> 1,361.46

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32195

Attachment #9227298 - Attachment is obsolete: true

I'm currently refactoring the visibility pass, which will result in all child pictures becoming raster roots - this should fix the scale issues in the existing code that caused the regression when trying to land this.

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
Resolution: --- → INCOMPLETE

Hi Glen, is this bug fixed now by the recent visibility pass work?

Flags: needinfo?(gwatson)

Fixed as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1749380

Flags: needinfo?(gwatson)
Depends on: 1749380
Resolution: INCOMPLETE → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: