Open Bug 1697447 Opened 4 years ago Updated 4 years ago

Disabled/Enabled Menu items have no visual differences with Dark/Light themes enabled

Categories

(Firefox :: Menus, defect, P2)

Desktop
macOS
defect

Tracking

()

Tracking Status
firefox86 --- disabled
firefox87 --- affected
firefox88 --- affected

People

(Reporter: rdoghi, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-hamburger-menu][priority:2c])

Attachments

(1 file)

[Affected versions]
Beta 87
Nightly 88

[Affected platforms]
Mac OsX

[Steps to reproduce]

  1. Open the Firefox browser and change to a Dark/Light theme.
  2. Reach the History submenu from the Library menu.
  3. Close at least one separate Window.

[Expected result]
There should be a Visual Difference between Enabled/Disabled submenu items.
Recently Closed Tabs/Windows should have minor visual differences if one of them is disabled.

[Actual result]
There are no Visual differences between enabled/disabled menu items when Dark or Light Theme is applied.

Attached image tabsDisabled.png (deleted) —

Recently Closed tabs is disabled since there are no recently closed tabs and yet theres no difference between the two menu items.

Strangely, this only seems to be the case in the History subview when opened from the Library button. If opened from the AppMenu (AppMenu > Library > History), the menuitems have the proper disabled appearance.

Priority: -- → P3

I verified this appears to only happen under the Library button, and it also shows the submenu arrow even though no submenu exists when the menu item is disabled. Library menu and toolbar icon is not being shown by default for new profiles after MR1, but will continue to be present for existing profiles and was restyled, so I think this is a somewhat significant polish issue.

Priority: P3 → P2
Whiteboard: [proton-hamburger-menu] → [proton-hamburger-menu][priority:2c]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: