Closed
Bug 1697747
Opened 4 years ago
Closed 4 years ago
Ignore already destroyed root node resources in onResourceAvailable callback
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(Fission Milestone:M7, firefox88 fixed)
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In the inspector, there are a few places where ROOT_NODE resources are used (See https://searchfox.org/mozilla-central/search?q=ROOT_NODE&path=devtools%2Fclient%2F&case=true®exp=false)
Most of the time, the inspector check if the ROOT_NODE is associated with a top level target (via resource.targetFront.isTopLevel).
The issue is that the ROOT_NODE resource is a front, and as a front, it can be destroyed, and when it's destroyed, its targetFront property is nullified, which causes exception when trying to access a property on it.
|
Assignee | |
Comment 1•4 years ago
|
||
It looks like this reduces the number of failures in browser_toolbox_backward_forward_navigation.js.
|
||
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P2
|
||
Updated•4 years ago
|
Attachment #9208337 -
Attachment description: Bug 1697747 - [devtools] Ignore already destroyed root node resources in onResourceAvailable callback. r=jdescottes. → Bug 1697747 - [devtools] Ignore already resources which are fronts and already destroyed in onResourceAvailable callback. r=jdescottes.
|
||
Updated•4 years ago
|
Fission Milestone: --- → M8
Whiteboard: dt-fission-m3-mvp
|
|
||
Updated•4 years ago
|
Attachment #9208337 -
Attachment description: Bug 1697747 - [devtools] Ignore already resources which are fronts and already destroyed in onResourceAvailable callback. r=jdescottes. → Bug 1697747 - [devtools] Ignore resources which are fronts and already destroyed in onResourceAvailable callback. r=jdescottes.
|
|
||
Updated•4 years ago
|
Attachment #9208337 -
Attachment description: Bug 1697747 - [devtools] Ignore resources which are fronts and already destroyed in onResourceAvailable callback. r=jdescottes. → Bug 1697747 - [devtools] Ignore already resources which are fronts and already destroyed in onResourceAvailable callback. r=jdescottes.
|
|
||
Updated•4 years ago
|
Attachment #9208337 -
Attachment description: Bug 1697747 - [devtools] Ignore already resources which are fronts and already destroyed in onResourceAvailable callback. r=jdescottes. → Bug 1697747 - [devtools] Ignore already destroyed root node resources in onResourceAvailable callback. r=jdescottes.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/596ffca60028
[devtools] Ignore already destroyed root node resources in onResourceAvailable callback. r=jdescottes.
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
|
|
||
Updated•4 years ago
|
Fission Milestone: M8 → M7
You need to log in
before you can comment on or make changes to this bug.
Description
•