Closed Bug 1698063 Opened 4 years ago Closed 4 years ago

The "Saved to Library!" toast is displayed connected to the hamburger menu although the new Proton menu no longer has Library section

Categories

(Firefox :: Menus, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: tbabos, Assigned: mconley)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-hamburger-menu])

Attachments

(1 file)

Affected Version:
Latest Nightly 88.0a1 (2021-03-12)
browser.proton.enabled

Tested Platforms:
Windows 7/10, MacOs

Steps to reproduce:

  1. Go to any site and bookmark it
  2. Notice the "Saved to Library!" toast dropping down from the hamburger menu button
  3. Open the menu

Expected Result:
The user expects a section named "Library" which was suggested by the displayed toast.

Actual Result:
Due to Proton changes the library section is no longer available in the menu.
Screenshot: https://drive.google.com/file/d/1Up_dLAF8bwxSD8lW-_0fs3K_4XMBSM2h/view

Blocks: 1688173

For users without the library icon in toolbar, the toast message should be updated to: Saved to bookmarks

Romain, for users that will still have the library icon in the toolbar, I assume toast will continue to drop from there? And in that case the string would be: Saved to library

Flags: needinfo?(rtestard)

Users that have the toolbar library icon have a different animation (star dropped into the toolbar icon without the toast).
So I think for the purpose of this bug we should limit scope to adjusting the string from "Saved to Library!" to "Saved to bookmarks"

Flags: needinfo?(rtestard)

Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.

Priority: -- → P1
Assignee: nobody → mconley

Not porting to Fluent here because updating ConfirmationHint to use Fluent
strings for all hints is out of scope.

Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee6e2d058168 Update confirmation hint string for bookmarking. r=flod
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified-fixed on the latest Nightly 89.0a1 (2021-03-25) on Windows 7/10, MacOS 10.15 and Ubuntu 16.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: