The "Saved to Library!" toast is displayed connected to the hamburger menu although the new Proton menu no longer has Library section
Categories
(Firefox :: Menus, defect, P1)
Tracking
()
People
(Reporter: tbabos, Assigned: mconley)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-hamburger-menu])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Affected Version:
Latest Nightly 88.0a1 (2021-03-12)
browser.proton.enabled
Tested Platforms:
Windows 7/10, MacOs
Steps to reproduce:
- Go to any site and bookmark it
- Notice the "Saved to Library!" toast dropping down from the hamburger menu button
- Open the menu
Expected Result:
The user expects a section named "Library" which was suggested by the displayed toast.
Actual Result:
Due to Proton changes the library section is no longer available in the menu.
Screenshot: https://drive.google.com/file/d/1Up_dLAF8bwxSD8lW-_0fs3K_4XMBSM2h/view
Updated•4 years ago
|
Comment 1•4 years ago
|
||
For users without the library icon in toolbar, the toast message should be updated to: Saved to bookmarks
Romain, for users that will still have the library icon in the toolbar, I assume toast will continue to drop from there? And in that case the string would be: Saved to library
Comment 2•4 years ago
|
||
Users that have the toolbar library icon have a different animation (star dropped into the toolbar icon without the toast).
So I think for the purpose of this bug we should limit scope to adjusting the string from "Saved to Library!" to "Saved to bookmarks"
Comment 3•4 years ago
|
||
Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Not porting to Fluent here because updating ConfirmationHint to use Fluent
strings for all hints is out of scope.
Comment 6•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Reporter | ||
Comment 7•4 years ago
|
||
Verified-fixed on the latest Nightly 89.0a1 (2021-03-25) on Windows 7/10, MacOS 10.15 and Ubuntu 16.04.
Description
•