error on print base64 pdf with images with thermal printer
Categories
(Firefox :: PDF Viewer, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox86 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | + | fixed |
firefox89 | + | fixed |
People
(Reporter: ivan.altamirano, Assigned: emilio)
References
(Regressed 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [pdfjs-printing])
Attachments
(7 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0
Steps to reproduce:
Load a PDF from the server. The server provides the file in Base64 format.
Firefox displays the PDF file; however, when you try to print, the printer prints just a part of the images.
Actual results:
Print paper displays just a part of the images. If you download the file and print it from Adobe Acrobat Reader, the printer prints the file in the right way.
Expected results:
PDF.js should print the file in a right manner.
Comment 1•4 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Printing: Output' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Reporter | ||
Comment 2•4 years ago
|
||
This file was generated by the recorded process (into the other attached file). Please, try to print directly from the Firefox, Adobe Acrobat reader, and Chrome Browser. The last two will print in the right manner the file; however, Firefox will print the images (logo and barcode) split.
Assignee | ||
Comment 3•4 years ago
|
||
What is the output paper size of your printer so that we can try to reproduce it?
Assignee | ||
Comment 4•4 years ago
|
||
Also, if you could check if this reproduces on a build from https://nightly.mozilla.org, that'd be super-helpful.
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
So I took a closer look and I think I see what's going on. The attached PR should fix it.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
[Tracking Requested - why for this release]: Bug 1699313 improved similar cases for under-sized pages, see bug 1693989, bug 1698136, but it regressed this (arguably way less common) case. It'd be nice to not ship that regression.
Reporter | ||
Comment 8•4 years ago
|
||
(In reply to Emilio Cobos Γlvarez (:emilio) from comment #3)
What is the output paper size of your printer so that we can try to reproduce it?
Hello Emilio,
Paper size 80mm like this printer:
https://www.aliexpress.com/item/2019658459.html
Reporter | ||
Comment 9•4 years ago
|
||
(In reply to Emilio Cobos Γlvarez (:emilio) from comment #4)
Also, if you could check if this reproduces on a build from https://nightly.mozilla.org, that'd be super-helpful.
I've printed the same file as I attached, and I got the same error on Nightly Build (2021.03.26). Please, check the new attached file.
Assignee | ||
Comment 11•4 years ago
|
||
(In reply to ivan.altamirano from comment #8)
Paper size 80mm like this printer:
https://www.aliexpress.com/item/2019658459.html
Thanks Ivan. Is it that specific printer model? I might be able to get that and reproduce the bug here.
Reporter | ||
Comment 12•4 years ago
|
||
(In reply to Emilio Cobos Γlvarez (:emilio) from comment #11)
(In reply to ivan.altamirano from comment #8)
Paper size 80mm like this printer:
https://www.aliexpress.com/item/2019658459.htmlThanks Ivan. Is it that specific printer model? I might be able to get that and reproduce the bug here.
You can find in Google:
dinon thermal receipt printer 9321
I could not find any site in English sorry, You should use a translator to find specs
Updated•4 years ago
|
Reporter | ||
Comment 14•4 years ago
|
||
Comment 15•4 years ago
|
||
Cherry-pick of upstream commit:
https://github.com/mozilla/pdf.js/pull/13145
Comment 16•4 years ago
|
||
We'll still need a new pdf.js update bug to pick up Emilio's fix for 89+, but attached is a cherry-pick patch for Beta anyway.
Assignee | ||
Comment 17•4 years ago
|
||
Comment on attachment 9213351 [details]
Bug 1698414 - Improve rendering of oversized pages. r=bdahl
Beta/Release Uplift Approval Request
- User impact if declined: Some PDF pages that are too big for the target destination won't show up completely.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: print preview the attachment in this bug to A4 for example. May be worth checking also other prints from bug 1693989 to ensure we also don't change the undersized page case.
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Relatively straight-forward CSS change in pdf.js
- String changes made/needed: none
Assignee | ||
Updated•4 years ago
|
Comment 18•4 years ago
|
||
Comment on attachment 9213351 [details]
Bug 1698414 - Improve rendering of oversized pages. r=bdahl
Approved for 88.0b7.
Comment 19•4 years ago
|
||
uplift |
Assignee | ||
Comment 20•4 years ago
|
||
Let's reopen because I still need to check the issue with the thermal printer, which may have a different root cause...
Reporter | ||
Comment 21•4 years ago
|
||
Emilio,
I got the same error on this version of Firefox Nightly. (Updated today).
Updated•4 years ago
|
Assignee | ||
Comment 22•4 years ago
|
||
(In reply to ivan.altamirano from comment #21)
I got the same error on this version of Firefox Nightly. (Updated today).
Hmm, that's too bad, that means I probably need to get my hands on one of those thermal printers... Will look into whether I can expense it or what not. Thanks for testing!
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 23•4 years ago
|
||
Jonathan, I've heard you have a thermal printer, is there any chance you could take a look and see if comment 0 reproduces in your printer? Any other info that could be useful? Thanks!
Comment 24•4 years ago
|
||
Confirming that everything looks good using a regular printer (HP MFP M28a - A4 mode).
Tested on Windows 10 x64 using latest Nightly 89.0a1 (buildID 20210406152948) and 88.0b8 (buildID 20210406185740).
However, we don't have access to a thermal printer therefore we cannot tell for sure if this issue is completely fixed or not.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 25•3 years ago
|
||
(In reply to Emilio Cobos Γlvarez (:emilio) from comment #23)
Jonathan, I've heard you have a thermal printer, is there any chance you could take a look and see if comment 0 reproduces in your printer? Any other info that could be useful? Thanks!
Let's try to find someone else with a thermal printer, or maybe just buy one and expense it (should be pretty cheap).
Emilio, do you still want to work on this bug?
Updated•3 years ago
|
Assignee | ||
Comment 26•2 years ago
|
||
Ok, so I expensed a printer, and it just arrived. It's the one from comment 8. However I just printed from it from Windows and it seems to work fine, I don't see the chopped image. Is there something in your printer settings that could be affecting this?
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 27•2 years ago
|
||
I tried to print the same file from Edge and the result was the same as in Firefox. Maybe this was a printer driver issue?
Reporter | ||
Comment 28•2 years ago
|
||
Hi there, I will try to install my printer in my RPI, wife's laptop, and any other laptop that I can find until the weekend. I will report to you this weekend (EDT)
Comment 29•2 years ago
|
||
(In reply to ivan.altamirano from comment #28)
Hi there, I will try to install my printer in my RPI, wife's laptop, and any other laptop that I can find until the weekend. I will report to you this weekend (EDT)
Hi Ivan -- just checking back, did you turn up any interesting results from this investigation that might help narrow down the possible source-of-badness or might help us reproduce?
Comment 30•2 years ago
|
||
Closing this bug as WORKSFORME for now given lack of response.
Description
•