Closed Bug 1698526 Opened 4 years ago Closed 4 years ago

Browser intermittently gets stuck in disabled state after cancelling modal dialog with ESC key

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Firefox 88
Desktop
All

Tracking

(firefox-esr78 unaffected, firefox86 unaffected, firefox87 disabled, firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- disabled
firefox88 --- fixed

People

(Reporter: pbz, Assigned: pbz)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-modals])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1696793 +++

I can still reproduce a similar issue to Bug 1696793 with the fix applied. The STR are a little bit different and doesn't always happen:

STR:

  1. Ensure prompts.windowPromptSubDialog = true.
  2. Close the browser window with quit warning enabled and at least two open tabs.
  3. Modal dialog appears, press ESC to close it and quickly click the window close button again.
  4. Quickly repeat step 2 and 3 until the close window button stops to function.

Expected:

Browser continues to operate normally after modal dialog dismissed.

Actual:

Modal dialog goes away but many things stop working, the new tab button is greyed out as well as many menu items. Cannot close window or quit, only apparent way to recover is to terminate the application or close all remaining tabs.
Using these STR I also get a shutdown hang, see Bug 1696397. There are already patches to address this issue, so only the UI disabled issue remains.

Tested on Linux on today's Nightly.

Here is a video showing the issue. Note that this is with the shutdown hang fixes applied. So when closing all tabs the browser shuts down properly.

I can reproduce it 100% by pressing and holding ESC while clicking the close button.

Paul is looking into this more - thanks!

Assignee: nobody → pbz

Set release status flags based on info from the regressing bug 1685313

It looks like this is MR1 only, so setting disabled for tracking 87 - let me know if that's wrong.

Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.

Priority: -- → P1
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/07524a7905f9 Ensure we call SubDialog close callbacks when closing a SubDialog that has not fully opened. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Has Regression Range: --- → yes
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: