Closed
Bug 1698554
Opened 4 years ago
Closed 3 years ago
Log strings and objects thrown from actor methods
Categories
(DevTools :: Framework, enhancement)
DevTools
Framework
Tracking
(firefox88 fixed)
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
While working on bug 1631451 I saw that actor methods throwing a string instead of an error object were poorly logged. We weren't diplaying anywhere that string.
We should improve that in order to make that easier to debug.
|
Assignee | |
Updated•4 years ago
|
Summary: Log strings throws from actor methods → Log strings and objects thrown from actor methods
|
|
Assignee | |
Comment 1•4 years ago
|
||
Like BrowsingContextTargetActor.detach which was throwing { error: wrongState }
and we were logging "(void 0)" because error.message was undefined,
while error was the thrown JS object.
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ea3c488ff31 [devtools] Improve error logging when a request fails with a custom exception. r=nchevobbe
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•