Closed
Bug 1698759
Opened 4 years ago
Closed 4 years ago
Make bookmarks menu look good in dark mode
Categories
(Core :: Widget: Cocoa, task)
Core
Widget: Cocoa
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: mbalfanz, Assigned: bugzilla)
References
Details
(Whiteboard: [mac:darkmode])
Attachments
(2 files)
Screenshot 2021-03-16 at 11.16.08.png
With the patch from bug 1697331, and widget.macos.respect-system-appearance set to true, the "Create Bookmark" dialog looks like in the attached screenshot in macOS Dark Mode.
The problems I see are:
- Input fields have a light background and light text, e.g. when adding a new folder
|
||
Comment 1•4 years ago
|
||
FieldText CSS color follows dark mode and returns white, but Field does not and also returns white.
Sounds like Field should return a dark color in this case.
|
||
Comment 2•4 years ago
|
||
Maybe controlBackgroundColor would be a good match for Field.
Depends on: 1700022
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 89.1 - Mar 22 - Apr 4
Points: --- → 2
|
|
Assignee | |
Comment 3•4 years ago
|
||
Changing MozCombobox isn't necessary to resolve the bug, but it has the same issue as Field: its text is set to controlTextColor but its background is hardcoded to white.
|
|
Assignee | |
Updated•4 years ago
|
Points: 2 → 1
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa3cd3ca2e4f
Set Field and MozCombobox to colorControlBackground. r=mac-reviewers,mstange
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•