Closed
Bug 1698876
Opened 4 years ago
Closed 3 years ago
Stop listening to DevToolsClient close from TargetFrontMixin
Categories
(DevTools :: Framework, enhancement)
DevTools
Framework
Tracking
(firefox89 fixed)
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
TargetMixin register a closed listener on DevToolsClient in order to call its destroy method:
https://searchfox.org/mozilla-central/rev/526a5089c61db85d4d43eb0e46edaf1f632e853a/devtools/client/fronts/targets/target-mixin.js#567
this.client.on("closed", this.destroy);
But that's useless because all fronts are destroyed when the client closes...
When the DevToolsClient is closed, we destroy all the Pools, which will destroy all the Fronts
https://searchfox.org/mozilla-central/source/devtools/client/devtools-client.js#624-626
https://searchfox.org/mozilla-central/source/devtools/shared/protocol/Pool.js#179-196
Having said that, removing this manual direct wire between closed event and TargetMixin.destroy may slightly change some timings and code orders....
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → poirot.alex
Attachment #9209765 -
Attachment description: Bug 1698876 - [devtools] Stop listening to DevToolsClient close from TargetFrontMixin → Bug 1698876 - [devtools] Stop listening to DevToolsClient close from TargetFrontMixin.
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3dbbcb763de7 [devtools] Stop listening to DevToolsClient close from TargetFrontMixin. r=nchevobbe
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•