Closed
Bug 1698920
Opened 4 years ago
Closed 3 years ago
Remove --panelview-toolbarbutton-hover-*/--panelview-toolbarbutton-active-*
Categories
(Firefox :: Theme, task, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: ntim, Assigned: mhowell)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-cleanups])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
These should use --button-secondary-hover-*/--button-secondary-active-*, since these are basically ghost buttons in basic components (but I could be misreading the spec).
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-584
|
||
Updated•4 years ago
|
Priority: -- → P5
|
|
||
Updated•4 years ago
|
Priority: P5 → P3
|
||
Comment 1•3 years ago
|
||
It looks like they just reuse --button-active-bgcolor and --button-hover-bgcolor. Foreground colours are set to inherit, which I think we may need to keep?
Points: --- → 1
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → mhowell
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•3 years ago
|
||
Also remove some associated color: inherit properties that don't appear
necessary; as far as I can tell, equivalent rules already exist everywhere
that these ones would match, so they're not having any effect.
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1470f1792c3f
Remove a couple of superflous CSS variables. r=desktop-theme-reviewers,Itiel
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•