Closed
Bug 1699111
Opened 3 years ago
Closed 3 years ago
Clarify code related to transport closing in DevToolsClient
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox89 fixed)
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Followup from bug 1631451 review:
https://phabricator.services.mozilla.com/D107988#inline-607862
_closed and _onClosed both refer to the transport rather than the client.
This should be renamed for clarity.
|
Assignee | |
Comment 1•3 years ago
|
||
This will better highlight what is closing. Not the DevToolsClient, but just the transport class.
|
|
Assignee | |
Comment 2•3 years ago
|
||
This better highlight that may only be the transport that is closed and not the whole client.
But at the end, both should follow the same lifecycle and be destroyed altogether.
|
||
Updated•3 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/37723169e2f2 [devtools] Rename transports onClosed callback to onTransportClosed. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/b674349624be [devtools] Rename DevToolsClient._closed to _transportClosed. r=jdescottes
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/37723169e2f2
https://hg.mozilla.org/mozilla-central/rev/b674349624be
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•