Closed
Bug 1699551
Opened 4 years ago
Closed 4 years ago
Preparations for initial native context menu support
Categories
(Core :: Widget: Cocoa, task)
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Whiteboard: [proton-context-menus][mac:mr1] )
Attachments
(3 files)
This bug is just to land some patches from bug 1698997 which are already ready.
|
Assignee | |
Comment 1•4 years ago
|
||
We fire it when the OS notifies us that the menu is already closed, so by that
time, there's nothing we can do to stop it.
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
We track two pieces of state: mNeedsRebuild and mIsOpen.
mNeedsRebuild is set to true on DOM mutations that require a rebuild, and set no
false when RebuildMenu() is done.
mIsOpen is set to true in MenuOpened() and set to false in MenuClosed().
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/6455c4623d94
Ignore cancellations of popuphiding. r=harry
https://hg.mozilla.org/integration/autoland/rev/7a2d4b6343cf
Inline OnClose into MenuClosed. r=harry
https://hg.mozilla.org/integration/autoland/rev/70d5566772ce
Simplify nsMenuX state management. r=harry
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6455c4623d94
https://hg.mozilla.org/mozilla-central/rev/7a2d4b6343cf
https://hg.mozilla.org/mozilla-central/rev/70d5566772ce
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-649
You need to log in
before you can comment on or make changes to this bug.
Description
•