Closed Bug 1699624 Opened 4 years ago Closed 3 years ago

Consolidate and rename toolkit/themes/shared icons

Categories

(Toolkit :: Themes, task, P3)

task

Tracking

()

RESOLVED WONTFIX

People

(Reporter: sfoster, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-icons])

Attachments

(1 obsolete file)

Ahead of the proton icon updates, we want to align icons on a naming convention like so:

{base name}-{state}-{style}-{size}.svg

base-name: describes the feature or function (ie, bookmark, not star)
state: indicates a invariant that shows state, like blocked, muted, hidden
style: indicates if icon is distinct by being e.g. outlined or filled
size: default is 16x16, other icons are drawn for 12x12 or larger 20x20.

To reduce churn and noise, I suggest leaving the default size, state, style off. So, e.g. check.svg remains check.svg.

Blocks: proton-icons
Blocks: 1700124
No longer blocks: 1700124
Priority: -- → P1
Whiteboard: [proton-icons]
Attachment #9210216 - Attachment description: Bug 1699624 - Update toolkit/shared/icon names r?ntim → Bug 1699624 - Update toolkit/shared/icon names r?Standard8,dao
Attachment #9210216 - Attachment is obsolete: true

i'm bumping the renaming and consolidation down in priority. We'll get the new icons

Priority: P1 → P3

Moving this to cleanup. We'll get the new icons in place at their existing paths first, and edit the allowed-dupes list as necessary leaving this as cleanup work for later.

Assignee: sfoster → nobody
Assignee: nobody → sfoster
Status: NEW → ASSIGNED

After talking with a :harry and others, I don't think it makes sense to do a mass renaming to align our assets with this naming convention. When the opportunity comes up we should move towards that convention, in individual bugs as needed. Likewise, consolidation of icons needs separate bugs & patches case by case.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: