Closed Bug 1699660 Opened 4 years ago Closed 4 years ago

Better TRR confirmation follow-up

Categories

(Core :: Networking: DNS, enhancement, P2)

Product:
Core
Component:
Networking: DNS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(5 files)

Bug 1699660 - Make TRRService::ConfirmationContext implement nsITimerCallback r=#necko
(deleted), text/x-phabricator-request
Details
Bug 1699660 - Make CompleteConfirmation a member of TRRService::ConfirmationContext r=#necko
(deleted), text/x-phabricator-request
Details
Bug 1699660 - Move TRRIsOkay logic to ConfirmationContext and rename to RecordTRRStatus r=#necko
(deleted), text/x-phabricator-request
Details
Bug 1699660 - Make HandleConfirmationEvent a member function of ConfirmationContext r=#necko
(deleted), text/x-phabricator-request
Details
Bug 1699660 - Create ConfirmationWrapper to enforce logic separation r=#necko
(deleted), text/x-phabricator-request
Details
No description provided.

Some issues that might need addressing.

https://phabricator.services.mozilla.com/D107666#inline-609577

ConfirmationContext should implement the timer interface, this should move to ConfirmationContext

https://phabricator.services.mozilla.com/D107666#inline-608501

Restrict the PrefChange event to relevant prefs

https://phabricator.services.mozilla.com/D107666#inline-609527

Complete confirmation should move to ConfirmationContext.

https://phabricator.services.mozilla.com/D107666#inline-609522

Move logic from TRRiSOKay to ConfirmationContext

https://phabricator.services.mozilla.com/D107666#inline-609571

What I'm not super sure about is if our handling of CheckURIPrefs is correct

Attachment #9218285 - Attachment description: Bug 1699660 - Move TRRIsOkay logic to ConfirmationContext r=#necko → Bug 1699660 - Move TRRIsOkay logic to ConfirmationContext and rename to RecordTRRStatus r=#necko
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2a4104ef0e5d Make TRRService::ConfirmationContext implement nsITimerCallback r=necko-reviewers,dragana https://hg.mozilla.org/integration/autoland/rev/2e4273ae2d2b Make CompleteConfirmation a member of TRRService::ConfirmationContext r=necko-reviewers,dragana https://hg.mozilla.org/integration/autoland/rev/413330d7f951 Move TRRIsOkay logic to ConfirmationContext and rename to RecordTRRStatus r=necko-reviewers,dragana https://hg.mozilla.org/integration/autoland/rev/6d4aa1994e5a Make HandleConfirmationEvent a member function of ConfirmationContext r=necko-reviewers,dragana https://hg.mozilla.org/integration/autoland/rev/5e686902e9b5 Create ConfirmationWrapper to enforce logic separation r=necko-reviewers,dragana
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: