Closed
Bug 1699696
Opened 4 years ago
Closed 3 years ago
MIPS: Wasm baseline compiler unsupported, missing code in IsValidStackMapKey
Categories
(Core :: JavaScript: WebAssembly, defect, P5)
Tracking
()
RESOLVED
FIXED
People
(Reporter: lth, Assigned: lth)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
js::wasm::IsValidStackMapKey (near the end of WasmBaselineCompile.cpp) needs an implementation for MIPS64. For now, it's OK to just return true.
(Without this, most baseline compiler tests fail.)
|
Assignee | |
Comment 1•4 years ago
|
||
Without this fix, no baseline compiler tests pass.
Depends on D109070
|
||
Updated•4 years ago
|
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•4 years ago
|
||
The patch is just a stopgap, so leave bug open for a proper fix.
Keywords: leave-open
|
|
Assignee | |
Updated•4 years ago
|
Severity: -- → S1
Priority: -- → P3
|
|
||
Updated•4 years ago
|
Attachment #9210285 -
Attachment description: Bug 1699696 - stopgap mips64 implementation of isValidStackMapKey. r?nbp → Bug 1699696 - Stopgap mips64 implementation of isValidStackMapKey. r?nbp
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8172419ecdff
Stopgap mips64 implementation of isValidStackMapKey. r=nbp DONTBUILD
|
||
Updated•4 years ago
|
Severity: S1 → S3
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•4 years ago
|
Assignee: lhansen → nobody
Status: ASSIGNED → NEW
|
|
Assignee | |
Updated•3 years ago
|
Priority: P3 → P5
|
|
Assignee | |
Updated•3 years ago
|
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Assignee: nobody → lhansen
|
|
||
Updated•3 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•