Remove DeviceProximityEvent
Categories
(Core :: DOM: Core & HTML, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: saschanaz, Assigned: saschanaz)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
It's not in the spec anymore, and it has been disabled everywhere for years. https://searchfox.org/mozilla-central/rev/31b583bbcc9cfaacd93e785c05dda0e87d7cca4e/modules/libpref/init/StaticPrefList.yaml#1430
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Note that this removes window.ondeviceproximity
and window.onuserproximity
which unexpectedly have been exposed unconditionally.
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e17c6f92b2bf Remove DeviceProximityEvent and UserProximityEvent r=agi,annevk,smaug
Comment 3•3 years ago
|
||
bugherder |
Comment 4•3 years ago
|
||
Hi all,
This is a problematic removal for KaiOS. Can we back this out and only remove the Android specific parts as a compromise?
Thanks!
Assignee | ||
Comment 5•3 years ago
|
||
Hi Fabrice,
I see it's disabled in the gecko-b2g fork, where does KaiOS enable it? (Sorry, the GitHub search is not very good. 😬)
Comment 6•3 years ago
|
||
Hi Kagami, we enable it on a per-device model basis, in a preference file that is not in gecko but in the device customization.
Assignee | ||
Comment 7•3 years ago
|
||
Thanks for the quick reply. Is there a good way to see which flags are provided in KaiOS as an option but disabled by default in Gecko? We want to also remove DeviceLightEvent, so it would be helpful to know that.
Comment 8•3 years ago
|
||
(In reply to Kagami :saschanaz from comment #7)
Thanks for the quick reply. Is there a good way to see which flags are provided in KaiOS as an option but disabled by default in Gecko? We want to also remove DeviceLightEvent, so it would be helpful to know that.
Not really I'm afraid. Feel free to needinfo me if you have doubts and/or to ping me in matrix (my handle is 'fabrice').
Assignee | ||
Comment 9•3 years ago
|
||
Hmm, could you do a quick check if KaiOS is using DeviceLightEvent (device.sensors.ambientLight.enabled
)? Also, is KaiOS using both DeviceProximityEvent/UserProximityEvent or is it only using one of them?
Comment 10•3 years ago
|
||
We use the DeviceLightEvent and the UserProximityEvent ones, but not DeviceProximityEvent from what I see.
Assignee | ||
Comment 11•3 years ago
|
||
Cool, I'll restore only UserProximityEvent then.
Assignee | ||
Comment 12•3 years ago
|
||
Hi Fabrice again,
Could you check whether ondevicelight
and onuserproximity
are used or KaiOS only uses them in addEventListener
form? Thanks!
(What's the best way to search in the codebase without cloning it? Does KaiOS also have a searchfox instance?)
Comment 13•3 years ago
|
||
Both onXXX
and addEventListener()
forms are used.
There is a searchfox instance for the gecko fork used by KaiOS at https://searchfox.org/kaios/source/ but unfortunately it would not help you much here since the UI where these events are used is in a private repository.
Assignee | ||
Updated•3 years ago
|
Comment 14•3 years ago
|
||
Hi @Kagami,
I'm documenting this change for FF89 in MDN content bug 4308. My understanding is that
DeviceProximityEvent
is removed, along with ondeviceproximity.UserProximityEvent
,onuserproximity
are still present behinddevice.sensors.proximity.enabled
(which is false by default on desktop).- Is the behaviour same for desktop and android (or was this only renabled for android?). If it is restored to android how are users supposed to set the preference, when there is no preference UI on current Android Firefox?
Thanks!
Assignee | ||
Comment 15•3 years ago
|
||
Hi Hamish,
You are correct, so I'm just answering the question:
Is the behaviour same for desktop and android (or was this only renabled for android?). If it is restored to android how are users supposed to set the preference, when there is no preference UI on current Android Firefox?
This is disabled everywhere including Android, and users are not expected to enable it again. It's present only for KaiOS for now.
Comment 16•3 years ago
|
||
Thanks very much. I think all the work for this is done now - updated in BCD and in docs. Tracking for that in https://github.com/mdn/content/issues/4308
Comment 17•3 years ago
|
||
Docs completed, so setting this to DDC. Thanks Hamish!
Description
•