No border is shown in "search Toolbar"
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox86 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | + | verified |
firefox89 | + | verified |
People
(Reporter: muirpablo, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
image/jpeg
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
Description
Borders missing in "search bar in toolbar"
Tested on
Windows10 64bit : Reproducible only on left side
Ubuntu 20 : Reproducible on ALL Sides
macos 10.14 : Not reproducible.
Firefox Release 86.0.1 not reproducible
Firefox beta 87.0 not reproducible
Firefox Nightly 88.0a1 reproducible
** This is without proton, since on nightly proton is off by default**
Steps
- go to about:preferences#search
- enable Add search bar in toolbar
- type anything in searchbar in toolbar
- check the border
actual results
On windows10 the left border is missing, On ubuntu ALL BORDERS ARE MISSING.
expected results
borders should be visible.
This is without proton, since on nightly proton is off by default.
Updated•4 years ago
|
Comment 4•4 years ago
|
||
[Tracking Requested - why for this release]: visual regression
Comment 5•4 years ago
|
||
I suspect https://hg.mozilla.org/mozilla-central/rev/d54f1666473acafb01bbcb6d50846a8cf6a379d2 that unset border-width on non-proton
This is the mozregression done with windows10
build info
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VMJbiXw4QiWHXzjlBU_cNw/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: 7251d2406edd9343c1803c837a634a829d0a06d1
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d0238d81621ef6c0377b7328e71bf7c7ce8a610f&tochange=7251d2406edd9343c1803c837a634a829d0a06d1
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: VMJbiXw4QiWHXzjlBU_cNw
Log
Bug 1692046 - Add dark mode address bar and arrowpanel-border colors (Proton). r=mak,dao
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
Comment 9•4 years ago
|
||
bugherder |
Comment 10•4 years ago
|
||
Please nominate this for Beta approval when you get a chance.
Assignee | ||
Comment 11•4 years ago
|
||
Comment on attachment 9210768 [details]
Bug 1699821 - Restore border to standalone search bar. r?mak!
Beta/Release Uplift Approval Request
- User impact if declined: Visual regression in non-Proton 88.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very small CSS-only patch.
- String changes made/needed:
Comment 12•4 years ago
|
||
Comment on attachment 9210768 [details]
Bug 1699821 - Restore border to standalone search bar. r?mak!
Approved for 88.0b3.
Comment 13•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Updated•4 years ago
|
Comment 14•4 years ago
|
||
This issue is verified as fixed on Ubuntu 20.04 and Windows 10 with Beta 88.0b3 and our latest Nightly build 89.0a1 (2021-03-26).
Updated•4 years ago
|
Description
•