Avoid using chrome://global/skin icons which will get proton treatment in 89.
Categories
(DevTools :: Shared Components, task, P2)
Tracking
(firefox89 fixed)
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: sfoster, Assigned: sfoster)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-foundations])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
A lot of the shared icons in toolkit/themes/shared/icons are being updated with a lighter stroke and Proton-y style. Devtools references some of its icons directly from chrome://global/skin/icons/*.svg. To avoid a mis-mash of old and new we'll need to temporarily create copies for use from chrome://devtools/skin/images/.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Backed out for causing build bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/16e333f832452ffe2cfe92847032792a00402cd8
Failure log: https://treeherder.mozilla.org/logviewer?job_id=334173455&repo=autoland&lineNumber=70596
Assignee | ||
Comment 4•4 years ago
|
||
Thanks. I wasn't sure how the allowed-dupes.mn worked. Looks like I need to list both sides of the duplication.
Comment 6•4 years ago
|
||
Backed out for causing failures at browser_styleinspector_tooltip-background-image.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/768e04aaea528ec9a0af31c49708cf73ad505a2a
Failure log: https://treeherder.mozilla.org/logviewer?job_id=334230388&repo=autoland&lineNumber=4200
Assignee | ||
Comment 8•4 years ago
|
||
Thanks for the backout. I've identified the issue and devtools tests were passing so its re-pushed.
Comment 9•4 years ago
|
||
bugherder |
Comment 10•4 years ago
|
||
Updated•2 years ago
|
Description
•