Closed Bug 1699858 Opened 4 years ago Closed 4 years ago

Avoid using chrome://global/skin icons which will get proton treatment in 89.

Categories

(DevTools :: Shared Components, task, P2)

task

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: sfoster, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-foundations])

Attachments

(1 file)

A lot of the shared icons in toolkit/themes/shared/icons are being updated with a lighter stroke and Proton-y style. Devtools references some of its icons directly from chrome://global/skin/icons/*.svg. To avoid a mis-mash of old and new we'll need to temporarily create copies for use from chrome://devtools/skin/images/.

Whiteboard: [proton-foundations]
Priority: -- → P2
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d7fcfd34752 Avoid using the toolkit/global icons which are about to change for proton. r=nchevobbe,jdescottes

Thanks. I wasn't sure how the allowed-dupes.mn worked. Looks like I need to list both sides of the duplication.

Flags: needinfo?(sfoster)
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9904b1dafade Avoid using the toolkit/global icons which are about to change for proton. r=nchevobbe,jdescottes
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af4be63b7659 Avoid using the toolkit/global icons which are about to change for proton. r=nchevobbe,jdescottes

Thanks for the backout. I've identified the issue and devtools tests were passing so its re-pushed.

Flags: needinfo?(sfoster)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/6be44ee99e24 Port bug 1699858 - Avoid using chrome://global/skin icons which will get proton treatment in 89. rs=bustage-fix
Component: CSS and Themes → Shared Components
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: