[Affected versions]:

• Firefox Nightly 89.0a1 (Build ID: 20210322174641)
• Firefox Beta 88.0b1 (Build ID: 20210322185611)

[Affected Platforms]:

• Mac 11.2.3
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest version of Firefox Nightly installed.
• Have saved on your computer a CSV file that contains only valid logins.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to the "about:logins" page.
3. Click on the Menu button.
4. Select the “Import from a File…” option.
5. Select the CSV file from prerequisites and click on the “Open” button from the “Import Logins File” picker.
6. Observe the string displayed next to the “Duplicate logins: <no of duplicate logins>” and “Errors: <no of duplicate logins>” rows.

[Expected result]:

• The “(not imported)” string is not displayed.

[Actual result]:

• The “(not imported)” string is displayed.

[Notes]:

• Based on the mock-ups the “not imported” string should not be displayed if the number of these logins is 0.
• Attached a screenshot with the issue.

Thanks for logging this. We should hide the "(not imported)" elements when the count is 0.

hey. i would like to work on this bug!

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on
     Element/Matrix
     in the #introduction channel. They're there to help you get started.
   • You can also read the
     Developer Guide,
     which has answers to most development questions.
3. Start working on this bug. You will most likely need to modify the strings in aboutLogins.ftl so that a zero count will not display the "(not imported") div or determine some other way of hiding the "(not imported") divs when the "no-change" count is zero and/or when the "error" count is zero in aboutLoginsImportReport.js.
   • If you have any problems with this bug,
     please comment on this bug and set the needinfo flag for me.
     Also, you can find me and my teammates on the #lockwise-desktop channel on
     Element/Matrix
     most hours of most days.
4. Build your change with mach build and test your change with
   mach test toolkit/components/passwordmgr/ --headless.
   Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review.
   Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch,
   I'll mark it for checkin or push it to autoland.
   Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

hello.
I followed the steps and was able to reproduce and solve the bug too.
I have committed my changes with hg commit -m 'commit msg' for now.
What do I do next I tried to follow How to submit the patch guide you mentioned above but couldn't find what to do next.
A little Help here :/

Hi Kaira, it looks like you successfully submitted the patch to Phabricator. The patch is currently in "Changes Planned", is it ready for review? If it is, you can scroll to the bottom of the patch on Phabricator and select "Add Action" which will bring up an option to submit the patch for review.

Apologies for not getting back to you quicker, I was out of the office yesterday. Let me know if you have any other questions!

yes. the patch is ready to review. please look at the patch
Thanks.

hii. it seems that the patch is in "accepted" state for this bug.
What should I be doing next??
would you help me to found a bug for my next contribution or should I be finding it on my own.? ^_^
I am participating in outreach for the "Improve the screenshots" project.
Thanks a lot for all the help!!!!

Hi Kaira, there's currently nothing you need to do with this bug! If the patch lands successfully (which it should), someone on the release team will verify that the patch landed on mozilla-central, which will change the state of this bug. After it lands on mozilla-central, you will have officially contributed to Firefox!

As for finding your next bug, I would check with your mentor first. You do have a mentor for your time in Outreachy right? I don't know all of the details for how the program works...I want to make sure password manager isn't taking time from the screenshots project!

yeah i have sfoster and emalysz for the project mentors.
if you think there is a bug I can work on. i ll be glad.
i ll try to find a bug I can work on until then.

https://hg.mozilla.org/mozilla-central/rev/33850682363d

I have verified this issue using the latest Nightly 89.0a1 (Build ID: 20210411210108) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

• The "(not imported)" string is no longer displayed when the number of duplicate logins and errors is equal to 0.