Factor in syncing state when opening remote tabs and fxa panels
Categories
(Firefox :: Menus, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | --- | verified |
firefox89 | --- | verified |
People
(Reporter: emmamalysz, Assigned: emmamalysz)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression, Whiteboard: [proton-hamburger-menu] )
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
In Bug 1698492, we always set the data-l10n-id
to the "Sync now" default:
https://searchfox.org/mozilla-central/rev/1758450798ae14492ba28b695f48143840ad6c5b/browser/base/content/browser-sync.js#543-544
https://searchfox.org/mozilla-central/rev/1758450798ae14492ba28b695f48143840ad6c5b/browser/components/customizableui/CustomizableWidgets.jsm#619-620
However, we can be mid-sync and sometimes should have the "Syncing" label instead.
We should check for the "active" state on the sync now button.
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Comment 2•4 years ago
|
||
Set release status flags based on info from the regressing bug 1698492
Comment 4•4 years ago
|
||
bugherder |
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9211109 [details]
Bug 1700431: take syncing state into account when setting datal10nid for sync now buttons
Beta/Release Uplift Approval Request
- User impact if declined: Label on "Sync now" button can be incorrect
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: *With proton enabled and signed into fxa
- Open firefox
- Open fxa panel
- Observe button label is "Syncing..." with a blue rotating icon
- Close panel
- Open panel again. If still syncing, it should be the same as step 3. If no longer syncing, it should say "Sync Now" with no icon.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): No string changes
- String changes made/needed: n/a
Assignee | ||
Updated•4 years ago
|
Comment 6•4 years ago
|
||
Comment on attachment 9211109 [details]
Bug 1700431: take syncing state into account when setting datal10nid for sync now buttons
Approved for 88.0b3.
Comment 7•4 years ago
|
||
bugherder uplift |
Comment 8•4 years ago
|
||
This issue is verified as fixed in Beta 88.0b3 and our latest Nightly build 89.0a1 (2021-03-26) on Windows 10, Mac OsX 11.0 and Ubuntu 20.04.
Updated•4 years ago
|
Description
•