Closed Bug 1700468 Opened 4 years ago Closed 4 years ago

Tracking bug for build and release of SeaMonkey 2.53.7 Final

Categories

(SeaMonkey :: Release Engineering, task)

SeaMonkey 2.53 Branch
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.7)

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1686851 +++

This is a tracking bug for Build and Release of the SeaMonkey 2.53.7 final.

Depends on: 1700470
Attached patch 1700468-version-cr-2537.patch (deleted) — Splinter Review

comm-release 2.53.7 version change r/a=me

Assignee: nobody → frgrahl
Attachment #9211145 - Flags: review+
Attachment #9211145 - Flags: approval-comm-release+
Attached patch 1700468-version-mr-2537.patch (deleted) — Splinter Review

mozilla-release 2.53.7 version change r/a=me

Attachment #9211146 - Flags: review+
Attachment #9211146 - Flags: approval-comm-release+

Snce the backport of bug #1390106, part3, the obsoleting "for each" javascript statement no more work.

The reason is the backport changes default version from JSVERSION_LATEST to JSVERSION_DEFAULT (with a value of zero), at it leads to the check always fail.

Since the code for "for each" still remains there, and it seems there are such extensions still used by SM users, it could be better to preserve the "for each" support, at least for a while. It could be done by either (partially) reverting that backport, or fix the check to no more use versions at all.

This one fixes the issue:

--- mozilla/js/src/frontend/Parser.h.orig       2020-08-10 14:30:34.000000000 +0300
+++ mozilla/js/src/frontend/Parser.h    2021-04-02 01:18:40.009761383 +0300
@@ -247,7 +247,7 @@ class ParserBase : public StrictModeGett
 #if !JS_HAS_FOR_EACH_IN
         return false;
 #else
-        return options().forEachStatementOption && versionNumber() >= JSVERSION_1_6;
+        return options().forEachStatementOption;
 #endif
     }
Flags: needinfo?(frgrahl)
Blocks: 1703363

See you in 2.53.7.1 and 2.53.8b1

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(frgrahl)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: