Closed Bug 1700527 Opened 4 years ago Closed 2 years ago

Intermittent browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out -

Categories

(Firefox :: Private Browsing, defect, P2)

Product:
Firefox
Component:
Private Browsing
Platform:
Unspecified
Linux
Type:
defect
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr102 --- wontfix
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- wontfix
firefox90 --- disabled
firefox110 --- wontfix
firefox111 --- wontfix
firefox112 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: pdahiya)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(5 files)

Bug 1700527 - disable browser_privatebrowsing_about.js on Linux_64_opt for frequent failures. r=#intermittent-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1700527 - disable browser_privatebrowsing_about.js on Linux_opt for frequent failures. r=#intermittent-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1700527 - disable browser_privatebrowsing_about.js on Win for frequent failures. r=#intermittent-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1700527 - Fix test to check link opening in new tab
(deleted), text/x-phabricator-request
Details
Bug 1700527 - Enable browser_privatebrowsing_about.js as the test was fixed but not re-enabled and order manifest. r=pdahiya,timhuang
(deleted), text/x-phabricator-request
Details

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=334233081&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/TYS1y1RTQtmqhtM5DRcoOg/runs/0/artifacts/public/logs/live_backing.log

[task 2021-03-24T00:28:30.263Z] 00:28:30     INFO - TEST-START | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js
[task 2021-03-24T00:30:00.285Z] 00:30:00     INFO - TEST-INFO | started process screentopng
[task 2021-03-24T00:30:00.625Z] 00:30:00     INFO - TEST-INFO | screentopng: exit 0
[task 2021-03-24T00:30:00.626Z] 00:30:00     INFO - Buffered messages logged at 00:28:30
[task 2021-03-24T00:30:00.626Z] 00:30:00     INFO - Entering test bound setup
[task 2021-03-24T00:30:00.627Z] 00:30:00     INFO - Leaving test bound setup
[task 2021-03-24T00:30:00.627Z] 00:30:00     INFO - Entering test bound test_myths_link
[task 2021-03-24T00:30:00.628Z] 00:30:00     INFO - Buffered messages logged at 00:28:31
[task 2021-03-24T00:30:00.628Z] 00:30:00     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Clicking private-browsing-myths opened https://example.com/private-browsing-myths in the same tab. - 
[task 2021-03-24T00:30:00.629Z] 00:30:00     INFO - Leaving test bound test_myths_link
[task 2021-03-24T00:30:00.630Z] 00:30:00     INFO - Entering test bound test_search_icon
[task 2021-03-24T00:30:00.630Z] 00:30:00     INFO - Buffered messages logged at 00:28:32
[task 2021-03-24T00:30:00.630Z] 00:30:00     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Should have the correct icon URL for the logo - "--newtab-search-icon:url(moz-extension://8d319d09-e272-4c19-9a50-b36b1d74043c/favicon.ico);" == "--newtab-search-icon:url(moz-extension://8d319d09-e272-4c19-9a50-b36b1d74043c/favicon.ico);" - 
[task 2021-03-24T00:30:00.630Z] 00:30:00     INFO - Leaving test bound test_search_icon
[task 2021-03-24T00:30:00.634Z] 00:30:00     INFO - Entering test bound test_search_handoff_on_keydown
[task 2021-03-24T00:30:00.635Z] 00:30:00     INFO - Buffered messages logged at 00:28:33
[task 2021-03-24T00:30:00.635Z] 00:30:00     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | in-content search has focus styles - true == true - 
[task 2021-03-24T00:30:00.637Z] 00:30:00     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Urlbar has hidden focus - 
[task 2021-03-24T00:30:00.637Z] 00:30:00     INFO - Awaiting for the urlbar panel to open
[task 2021-03-24T00:30:00.637Z] 00:30:00     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1280}]
[task 2021-03-24T00:30:00.637Z] 00:30:00     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_quickRestart”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1280}]
[task 2021-03-24T00:30:00.638Z] 00:30:00     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1280}]
[task 2021-03-24T00:30:00.642Z] 00:30:00     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | in-content search is disabled - true == true - 
[task 2021-03-24T00:30:00.643Z] 00:30:00     INFO - Urlbar panel opened
[task 2021-03-24T00:30:00.643Z] 00:30:00     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Urlbar has normal focus - 
[task 2021-03-24T00:30:00.644Z] 00:30:00     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | url bar has search text - 
[task 2021-03-24T00:30:00.646Z] 00:30:00     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | in-content search is not disabled - true == true - 
[task 2021-03-24T00:30:00.650Z] 00:30:00     INFO - Leaving test bound test_search_handoff_on_keydown
[task 2021-03-24T00:30:00.650Z] 00:30:00     INFO - Entering test bound test_search_handoff_on_composition_start
[task 2021-03-24T00:30:00.651Z] 00:30:00     INFO - Buffered messages logged at 00:28:34
[task 2021-03-24T00:30:00.651Z] 00:30:00     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Urlbar has hidden focus - 
[task 2021-03-24T00:30:00.652Z] 00:30:00     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 2213}]
[task 2021-03-24T00:30:00.652Z] 00:30:00     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_quickRestart”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 2213}]
[task 2021-03-24T00:30:00.653Z] 00:30:00     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 2213}]
[task 2021-03-24T00:30:00.653Z] 00:30:00     INFO - Buffered messages finished
[task 2021-03-24T00:30:00.654Z] 00:30:00     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out - ```
Flags: needinfo?(htwyford)
Summary: Intermittent High frequency browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out - → High frequency browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out -

Set release status flags based on info from the regressing bug 1616700

status-firefox87: --- → unaffected
status-firefox88: --- → unaffected
status-firefox89: --- → affected
status-firefox-esr78: --- → unaffected
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Points: --- → 3
Flags: needinfo?(htwyford)
Priority: P5 → P2
Whiteboard: [proton-address-bar]

Looks like this is Linux-only.

OS: Unspecified → Linux
Summary: High frequency browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out - → [Linux] High frequency browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out -

Thinking out loud:

  1. The test always times out at this Promise in test_search_handoff_on_composition_start(). That subtest tests that IME composition triggers handoff. The regressing patch made no obvious changes that would affect whether IME composition would be able to start.
  2. The failure screenshots always show that the Urlbar placeholder is "Google" and the about:privatebrowsing placeholder is DuckDuckGo. My change affected about:privatebrowsing, and it is exhibiting the correct behaviour: the test sets DuckDuckGo as the default engine.
  3. I can't reproduce these failures locally, nor can I reproduce them when running the affected chunk of mochitests in insolation on Try.

(In reply to Harry Twyford [:harry] from comment #2)

Looks like this is Linux-only.

There is also this tier2 failure on win ccov: https://treeherder.mozilla.org/logviewer?job_id=334520543&repo=mozilla-central&lineNumber=5168

Summary: [Linux] High frequency browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out - → [Mostly Linux] High frequency browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out -

There are 136 failures in the last 7 days.
The failures are mostly on linux1804-64* - opt

(In reply to Narcis Beleuzu [:NarcisB] from comment #8)

The failures are mostly on linux1804-64* - opt

The failure is on slow builds: asan, tsan, ccov, and linux debug.

Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/69d4599b59b6 disable browser_privatebrowsing_about.js on Linux_64_opt for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Keywords: leave-open
Whiteboard: [proton-address-bar][stockwell disable-recommended] → [proton-address-bar][stockwell disabled]
Priority: P2 → P1
Priority: P1 → P2

I'm mostly convinced that this test just revealed a pre-existing issue with IME composition in the new tab page search box. Also, for the other reasons listed in comment 3, I'm going to stop tracking this for Proton.

Whiteboard: [proton-address-bar][stockwell disabled] → [stockwell disabled]

Update:

There have been 43 failures within the last 7 days:

  • 3 failures on Windows 7 debug/opt
  • 1 failure on Windows 10 x64 WebRender debug
  • 3 failures on Windows 10 x64 CCov WebRender opt
  • 11 failures on Windows 10 x64 asan
  • 10 failures on Linux 18.04 x64 shippable opt
  • 15 failures on Linux 18.04 x64 opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=338426032&repo=mozilla-central&lineNumber=4767

[task 2021-05-01T22:54:51.937Z] 22:54:51     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Urlbar has hidden focus - 
[task 2021-05-01T22:54:51.938Z] 22:54:51     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 2240}]
[task 2021-05-01T22:54:51.939Z] 22:54:51     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 2240}]
[task 2021-05-01T22:54:51.941Z] 22:54:51     INFO - Buffered messages finished
[task 2021-05-01T22:54:51.944Z] 22:54:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out - 
[task 2021-05-01T22:54:51.945Z] 22:54:51     INFO - GECKO(5683) | MEMORY STAT | vsize 3205MB | residentFast 326MB | heapAllocated 123MB
[task 2021-05-01T22:54:51.946Z] 22:54:51     INFO - TEST-OK | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | took 45045ms
[task 2021-05-01T22:54:51.947Z] 22:54:51     INFO - checking window state
[task 2021-05-01T22:54:51.948Z] 22:54:51     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-05-01T22:54:51.949Z] 22:54:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Found a browser window after previous test timed out - 
[task 2021-05-01T22:54:51.950Z] 22:54:51     INFO - GECKO(5683) | must wait for focus
[task 2021-05-01T22:54:51.952Z] 22:54:51     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-05-01T22:54:51.954Z] 22:54:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js:161 - ReferenceError: ok is not defined
[task 2021-05-01T22:54:51.955Z] 22:54:51     INFO - Stack trace:
[task 2021-05-01T22:54:51.955Z] 22:54:51     INFO - test_search_handoff_on_composition_start@chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js:161:3
Whiteboard: [stockwell disabled] → [stockwell disabled][stockwell needswork:owner]
Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d9c56b1f13a disable browser_privatebrowsing_about.js on Linux_opt for frequent failures. r=ahal DONTBUILD
Whiteboard: [stockwell disabled][stockwell needswork:owner] → [stockwell disabled]
Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1875e7028675 disable browser_privatebrowsing_about.js on Win for frequent failures. r=intermittent-reviewers,ahal DONTBUILD
Assignee: htwyford → nobody
Status: ASSIGNED → NEW
Has Regression Range: --- → yes
Summary: [Mostly Linux] High frequency browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out - → [Mostly OS X 10.15] High frequency browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out -

This is basically permafailing on OS X after the changes in Bug 1756178, retriggers here.
This test gets skipped with pattern: verify || os == 'linux' || os == 'win' and most likely that's why is not failing on other platforms.
pdahiya, could you please have a look over these?

Flags: needinfo?(pdahiya)

Thanks for pointing. It is indeed fallout of bug 1756178 that has started opening links in new tab. Will submit patch with test fixed.

https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js#18

Flags: needinfo?(pdahiya)
Assignee: nobody → pdahiya
Pushed by pdahiya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eec5918719de Fix test to check link opening in new tab r=Mardak
Attachment #9318806 - Attachment description: Bug 1700527 - Enable browser_privatebrowsing_about.js as the test was fixed but not re-enabled. r=pdahiya,timhuang → Bug 1700527 - Enable browser_privatebrowsing_about.js as the test was fixed but not re-enabled and order manifest. r=pdahiya,timhuang
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/44489bc5eb6e Enable browser_privatebrowsing_about.js as the test was fixed but not re-enabled and order manifest. r=timhuang DONTBUILD
Keywords: leave-open
Summary: [Mostly OS X 10.15] High frequency browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out - → Intermittent browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out -
Whiteboard: [stockwell disabled]

https://hg.mozilla.org/mozilla-central/rev/44489bc5eb6e

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: