Closed Bug 1700539 Opened 4 years ago Closed 4 years ago

Allow negative scale in ScaleOffset type

Categories

(Core :: Graphics: WebRender, task)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox88 --- fixed
firefox89 --- fixed

People

(Reporter: gw, Assigned: gw)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → gwatson
Blocks: 1700366

Previously, a transform with a negative scale would result in a
new coordinate system being created when updating the spatial
tree.

This meant that a primitive in that space with a clip in a parent
space would create a clip mask (and was thus unable to be promoted
to a compositor surface).

This change allows negative scales to be part of the same coord
system (since they are still axis-aligned with the parent) and
avoid a clip mask in this case.

Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9040424c0cb8 Allow negative scale in ScaleOffset type. r=gfx-reviewers,kvark

Unfortunately this doesn't reproduce locally for me on an android emulator build. I'll debug it via logging debug information and doing try runs.

Flags: needinfo?(gwatson)
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be0f7947d378 Allow negative scale in ScaleOffset type. r=gfx-reviewers,kvark
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Comment on attachment 9211185 [details]
Bug 1700539 - Allow negative scale in ScaleOffset type.

Beta/Release Uplift Approval Request

  • User impact if declined: This patch significantly improves performance of many pages that use a webgl canvas when running webrender. It especially helps for users running sw-wr.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: If desired, can check via the picture cache debug overlay on the referenced sketchfab page.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch itself is fairly small, easy to back out if needed. It should only affect content that has a reflection transform, which is rare outside of webgl canvas.
  • String changes made/needed:
Attachment #9211185 - Flags: approval-mozilla-beta?

Comment on attachment 9211185 [details]
Bug 1700539 - Allow negative scale in ScaleOffset type.

Low-risk perf win, approved for 88.0b6.

Attachment #9211185 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Regressions: 1699854
Regressions: 1702662
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: