Closed
Bug 1700719
Opened 4 years ago
Closed 4 years ago
Crash in [@ mozilla::dom::CanonicalBrowsingContext::RequestRestoreTabContent]
Categories
(Firefox :: Session Restore, defect, P1)
Firefox
Session Restore
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox86 | --- | unaffected |
| firefox87 | --- | unaffected |
| firefox88 | --- | unaffected |
| firefox89 | + | fixed |
People
(Reporter: aryx, Assigned: u608768)
References
(Regression)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
3 crashes on 2+ machines in code landed in bug 1597499.
Maybe Fission related. (DOMFissionEnabled=1)
Crash report: https://crash-stats.mozilla.org/report/index/835d067d-3401-4524-afdc-d2fcb0210324
MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(!context->IsDiscarded())
Top 10 frames of crashing thread:
0 XUL mozilla::dom::CanonicalBrowsingContext::RequestRestoreTabContent docshell/base/CanonicalBrowsingContext.cpp:1752
1 XUL mozilla::dom::WindowGlobalParent::RecvRequestRestoreTabContent dom/ipc/WindowGlobalParent.cpp:1092
2 XUL mozilla::dom::PWindowGlobalParent::OnMessageReceived ipc/ipdl/PWindowGlobalParent.cpp:1501
3 XUL mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:6484
4 XUL mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2078
5 XUL mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1957
6 XUL mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:754
7 XUL mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal xpcom/threads/nsThreadUtils.h:534
8 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1155
9 XUL NS_ProcessPendingEvents xpcom/threads/nsThreadUtils.cpp:496
Flags: needinfo?(kmadan)
We're discard-checking the top-level context but not WindowGlobalParent::mBrowsingContext.
Assignee: nobody → kmadan
Status: NEW → ASSIGNED
Flags: needinfo?(kmadan)
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51fc422f096f
Discard-check both the top-level and current context before restoring, r=nika
|
||
Comment 4•4 years ago
|
||
Backed out for causing browser-chrome failures in CanonicalBrowsingContext.
Backout link: https://hg.mozilla.org/integration/autoland/rev/2b5850c18e69bcde444d19e189a806642dcff9b8
Flags: needinfo?(kmadan)
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
Attachment #9211497 -
Attachment description: Bug 1700719 - Discard-check both the top-level and current context before restoring, r?nika → Bug 1700719 - Discard-check all ancestors before restoring, r?nika
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0dadbfb3feca
Discard-check all ancestors before restoring, r=nika
|
||
Updated•4 years ago
|
Severity: -- → S2
Fission Milestone: --- → M7a
Priority: -- → P1
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•