Closed Bug 1701306 Opened 4 years ago Closed 4 years ago

Audit JS that sets `open=true` on anchors to see if that's still necessary after bug 1694285 lands

Categories

(Firefox :: Toolbars and Customization, task, P3)

task
Points:
2

Tracking

()

RESOLVED FIXED
89 Branch
Iteration:
89.2 - Apr 5 - Apr 18
Tracking Status
firefox89 --- fixed

People

(Reporter: mconley, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file)

In bug 1694285, I made it so that open=true is set on the nearest toolbarbutton on an anchorNode (or the anchorNode if no toolbarbutton is found) by panel.js when an anchored panel is opened.

dao noted that there are a few places that try to do the same thing elsewhere in the front-end code that are now made redundant because of bug 1694285. See https://phabricator.services.mozilla.com/D109939#3575029.

This bug is for checking to see if those places are redundant and if they can be removed.

Priority: -- → P3
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 89.2 - Apr 5 - Apr 18
Points: --- → 2
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d8aa8575c1d Remove custom code setting the "open" attribute on panel anchors. r=mconley
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/034a69e0a73e Remove custom code setting the "open" attribute on panel anchors. r=mconley

Backed out for causing browser-chrome failures in browser_page_action_menu

Backout link: https://hg.mozilla.org/integration/autoland/rev/98fbdf08cf7a66f0230c5cf280edaa94d4ea9d63

Push with failures

Failure log

Flags: needinfo?(dao+bmo)
Severity: -- → S3

This is green on try: https://treeherder.mozilla.org/jobs?repo=try&revision=9d3601de7432feaa04ad5c7900ee3e68fec22cc0
I'm guessing something around browser_page_action_menu.js and proton changed in the meantime.

Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c1f9288defa1 Remove custom code setting the "open" attribute on panel anchors. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1736207
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: