Closed Bug 1701361 Opened 4 years ago Closed 4 years ago

Reproducible crash on arstechnica [@ core::option::expect_failed | webrender::spatial_tree::SpatialTree::get_relative_transform_with_face ]

Categories

(Core :: Graphics: WebRender, defect, P2)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 + fixed
firefox89 + fixed

People

(Reporter: tnikkel, Assigned: gw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Using these steps I was able to bisect:

  1. make sure you don't have any arstechnica cookies.
  2. make sure you get the cookie dialog when opening arstechnica stories, for me this meant using a paris server on a vpn because they don't seem to show the cookie dialog in north america.
  3. open https://arstechnica.com/gadgets/2021/03/the-fairphone-2-hits-five-years-of-updates-with-some-help-from-lineageos/
  4. click "Show Purposes" on the cookie dialog
  5. try to scroll in the dialog

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cf0951d3d50c5d6bf0b631ae776ca12b87de4f33&tochange=23bd3cec784397ac9ce2d1d69fda2aa334ed9515

->bug 1684781

Note that I tested these steps in a nightly build with all of the display list building asserts as fatal from bug 1700812 (which are all of the asserts that I've come into when looking at the recent ASR problems) and we still hit the webrender crash and don't seem to hit the display list building asserts. (It's certainly still possible that the display list has an error in it that causes webrender to hit a problem but we just avoid the existing asserts somehow.)

Flags: needinfo?(gwatson)
Severity: -- → S2
Priority: -- → P2

(snip)

Confirmed with a local debug build, I hit the crash in the parent process and do not hit any display list building asserts.

[Tracking Requested - why for this release]:
I think the tracking 89 flag should be moved from bug 1695957 to this bug.

I was able to reproduce this with a VPN connection and get a WR capture that reproduces the panic in wrench.

Assignee: nobody → gwatson
Flags: needinfo?(gwatson)
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5238ee80d022 Fix nested scroll roots being selected for blend containers. r=gfx-reviewers,nical
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(gwatson)

Comment on attachment 9212092 [details]
Bug 1701361 - Fix nested scroll roots being selected for blend containers.

Beta/Release Uplift Approval Request

  • User impact if declined: Reproducible GPU process panic on some content
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small patch, fixes a clear panic, easy to back out of beta if any further problems are caused.
  • String changes made/needed:
Flags: needinfo?(gwatson)
Attachment #9212092 - Flags: approval-mozilla-beta?

Comment on attachment 9212092 [details]
Bug 1701361 - Fix nested scroll roots being selected for blend containers.

Approved for 88.0b6.

Attachment #9212092 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: