Closed Bug 1701448 Opened 4 years ago Closed 4 years ago

Tweak in-content page styling further for Proton

Categories

(Toolkit :: Themes, task)

Product:
Toolkit
Component:
Themes
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1701448 - Tweak in-content page styling further for Proton. r=#desktop-theme-reviewers
(deleted), text/x-phabricator-request
Details

Make further tweaks to match specs closer.

Depends on: 1690333
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Depends on: 1699250
No longer depends on: 1690333
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Assignee: nobody → ntim.bugs
Attachment #9212023 - Attachment description: Bug 1701448 - Tweak in-content page styling further for Proton. → WIP: Bug 1701448 - Tweak in-content page styling further for Proton.
Status: NEW → ASSIGNED
Attachment #9212023 - Attachment description: WIP: Bug 1701448 - Tweak in-content page styling further for Proton. → Bug 1701448 - Tweak in-content page styling further for Proton.
Attachment #9212023 - Attachment description: Bug 1701448 - Tweak in-content page styling further for Proton. → Bug 1701448 - Tweak in-content page styling further for Proton. r=#desktop-theme-reviewers
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3693f90f395d Tweak in-content page styling further for Proton. r=desktop-theme-reviewers,dao

Backed out for failures on browser_parsable_css.js along with Bug 1699917

backout: https://hg.mozilla.org/integration/autoland/rev/9eaad0de20ae76bdc98f3e8d82f5e39b40681a93

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=3693f90f395dee3127a99f18ad1434ddc1300b33&group_state=expanded&selectedTaskRun=DwugoB6vT9OjoGP2wTkeGg.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=335472074&repo=autoland&lineNumber=1618

[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - Buffered messages finished
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--blue-40-a10` is not referenced - 
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - Stack trace:
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - chrome://mochikit/content/browser-test.js:test_ok:1334
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:448
[task 2021-04-05T18:47:56.865Z] 18:47:56     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--grey-90` is not referenced - 
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - Stack trace:
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - chrome://mochikit/content/browser-test.js:test_ok:1334
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:448
[task 2021-04-05T18:47:56.866Z] 18:47:56     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-has-dir-attr’.  Ruleset ignored due to bad selector." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7fec7d9ff54a Tweak in-content page styling further for Proton. r=desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/7fec7d9ff54a

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1703229
Regressions: 1703458
Regressions: 1704024
Regressions: 1707589
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: