"Send Tab to Device" action lost visual feedback (blue tick) with proton enabled
Categories
(Firefox :: Toolbars and Customization, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | --- | disabled |
firefox89 | --- | verified |
firefox90 | --- | verified |
People
(Reporter: alberts, Assigned: mstriemer)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: nightly-community, regression, Whiteboard: [proton-toolbar] [priority:2a] [proton-uplift])
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
In current builds when sending a tab to a device there is a visual clue in form of a blue box with a tick icon and the wording "Send!" (see screenshot).
It appears underneath the page action buttons.
This is true for all ways to triggering it I could find, via the page action button, context menu and application menu.
Once proton is switched on only context menu and application menu, neither of which trigger the visual clue.
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Comment 1•4 years ago
|
||
I don't think this applies to the address bar anymore, if there should be a visual indicator then it should probably be elsewhere
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Set release status flags based on info from the regressing bug 1697191
Updated•4 years ago
|
Comment 3•4 years ago
|
||
UX says that we should hang the notification off of the FxA button (since in order to send a tab from one device to another you need an FxA account), and fall back to the AppMenu if the FxA button has been removed from the toolbar.
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 6•4 years ago
|
||
bugherder |
Comment 8•3 years ago
|
||
The patch landed in nightly and beta is affected.
:mstriemer, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Comment 9•3 years ago
|
||
(Answering for Mark)
Yes, it is. (And in general, any of the [proton-*][priority:2a]
bugs will be.)
It was the weekend, but I suspect an MR1-uplift request is coming in the near future… 😉
Assignee | ||
Comment 10•3 years ago
|
||
Comment on attachment 9217581 [details]
Bug 1701544 - Show Sent! confirmation when sending a tab to a device r?harry
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: 1. Send a tab to another device
- Verify there's a confirmation on success
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Adding back old behaviour, includes new tests.
- String changes made/needed: None
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 12•3 years ago
|
||
Verified that the messages for sent tabs are visible on Firefox 90.0a1 (2021-04-27). Tests were performed on Windows 10, macOS 10.15.7 and Ubuntu 20.04.
Comment 13•3 years ago
|
||
Comment on attachment 9217581 [details]
Bug 1701544 - Show Sent! confirmation when sending a tab to a device r?harry
Approved for 89 beta 6, thanks.
Comment 14•3 years ago
|
||
bugherder uplift |
Comment 15•3 years ago
|
||
Verified that the messages for sent tabs are visible on Firefox 89.0b6 (20210429010626 - treeherder build). Tests were performed on Windows 10, macOS 10.15.7 and Ubuntu 20.04.
Description
•