Browser Toolbox Inspector shows FX chrome stylesheets as inline
Categories
(DevTools :: Inspector, defect, P2)
Tracking
(firefox-esr78 unaffected, firefox87 unaffected, firefox88 unaffected, firefox89 verified, firefox90 verified)
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox87 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | --- | verified |
firefox90 | --- | verified |
People
(Reporter: Paenglab, Assigned: jdescottes)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
In Nightly when I inspect FX's chrome with the Browser Toolbox Inspector it shows all rules as they come inline and not from different stylesheets.
On the right it should show browser.css
instead of inline
.
Clicking on it does also not go to Style editor and jump to the correct line.
Assignee | ||
Comment 1•4 years ago
|
||
Regression from Bug 1685268, and in particular from https://hg.mozilla.org/integration/autoland/rev/8c0ee03d5bb6
Interestingly if you move to this changeset, the issue happens regardless of the devtools.testing.enableServerWatcherSupport preference
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
This is coming from https://searchfox.org/mozilla-central/rev/0e3d2eb698a51006943f3b4fb74c035da80aa2ff/devtools/client/fronts/style-rule.js#113-114
const resourceWatcher = this.targetFront.resourceWatcher;
if (resourceWatcher) {
used to be
const resourceWatcher = this.parentFront.resourceWatcher;
if (resourceWatcher) {
Difference is minimal but with the previous implementation, parentFront.resourceWatcher
was only defined if the resource watcher supported the STYLESHEET resource. With the new version, we assume that if we have a resource watcher, then we will have STYLESHEET resource support. Which is not true yet for the MBT.
Assignee | ||
Comment 3•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Set release status flags based on info from the regressing bug 1685268
Comment 6•4 years ago
|
||
bugherder |
Updated•3 years ago
|
Comment 7•3 years ago
|
||
Hello,
I have reproduced the issue using STR from comment 0, on an affected Nightly build 2021-03-28.
The fix was verified using the latest Nightly 90.0a1 (2021-05-09) and Firefox 89.0b10 (2021-05-09) on Windows 10x64 and Ubuntu 20.04.
The issue is not reproducing anymore.
Thanks!
Description
•