Stop using ContentSessionStore.jsm for SessionStore:RestoreDocShellState
Categories
(Firefox :: Session Restore, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: u608768, Assigned: u608768)
References
(Blocks 1 open bug)
Details
Attachments
(5 files, 1 obsolete file)
This should help avoid message ordering issues in the next patches. This also
moves all restore state on the CanonicalBrowsingContext into a separate
mRestoreState struct.
With the removal of the SessionStore:RestoreDocShellState message, the epoch
will no longer be updated otherwise, so we should include it in the Flush
message to ensure that messages are not being dropped.
Depends on D110333
This also makes it so that we will never fire SSTabRestored without first having
sent the associated SSTabRestoring event.
Depends on D110334
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
With the new "restore docshell state" codepath, we may be calling
updateTabLabelAndIcon() later than we did before, which means we may have
already set the tab label (in tabbrowser.init()), and it's incorrect to override
that label value with the session history entry's title.
|
||
Comment 6•4 years ago
|
||
Backed out for causing failures on /browser_UsageTelemetry_private_and_restore.js:
https://hg.mozilla.org/integration/autoland/rev/3c313de2c7d531be21cad167fe641a217fe2bf1c
Failure log: https://treeherder.mozilla.org/logviewer?job_id=337951019&repo=autoland&lineNumber=24195
Looks like it's relying on specific SSTabRestoring timing which changed. Will need to rework the patch a little.
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
A previous patch made it so we'd fire this after the full restore finished, but
some consumers expect this event prior to the completion of the load.
Depends on D110335
SessionStore factors both prefs into the decision about if a tab is restored
lazily, but this helper only uses the restore_tabs_lazily pref.
Depends on D114001
|
|
||
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1540ce1bad6b
https://hg.mozilla.org/mozilla-central/rev/41bb9b87829f
https://hg.mozilla.org/mozilla-central/rev/ebc0cf227611
https://hg.mozilla.org/mozilla-central/rev/644c228d9125
https://hg.mozilla.org/mozilla-central/rev/20f44b561529
Description
•