Closed
Bug 1702117
Opened 4 years ago
Closed 4 years ago
Remove CFR strings using -sync-brand-short-name
Categories
(Firefox :: Messaging System, task)
Firefox
Messaging System
Tracking
()
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: flod, Assigned: andreio)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
With MR1 we're getting rid of Sync intended as a feature name, and all the brand strings used across Firefox.
These have all been updated or removed in bug 1700638, but there are still two strings in asrouter.ftl
cfr-doorhanger-sync-bookmarks-ok-button = Turn on { -sync-brand-short-name }
cfr-doorhanger-sync-logins-ok-button = Turn on { -sync-brand-short-name }
I didn't touch them, because the guideline from product is that CFR will be removed as a whole. I understand that requires a considerable amount of work, but would it be possible to at least remove these two CFRs, so that we can also remove the brand from tree?
https://searchfox.org/mozilla-central/search?q=-sync-brand-short-name
|
||
Comment 1•4 years ago
|
||
NI @andrei to help confirm if its safe to remove these two strings in Fx89
Flags: needinfo?(andrei.br92)
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → andrei.br92
Flags: needinfo?(andrei.br92)
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9213742 -
Attachment description: WIP: Bug 1702117 - Remove CFR strings using -sync-brand-short-name → Bug 1702117 - Remove CFR strings using -sync-brand-short-name
|
|
||
Updated•4 years ago
|
Attachment #9213742 -
Attachment description: Bug 1702117 - Remove CFR strings using -sync-brand-short-name → WIP: Bug 1702117 - Remove CFR strings using -sync-brand-short-name
|
|
||
Updated•4 years ago
|
Attachment #9213742 -
Attachment description: WIP: Bug 1702117 - Remove CFR strings using -sync-brand-short-name → Bug 1702117 - Remove CFR strings using -sync-brand-short-name
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ac2582ca447
Remove CFR strings using -sync-brand-short-name r=pdahiya,fluent-reviewers,flod
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•