Closed Bug 1702135 Opened 4 years ago Closed 4 years ago

Enable new Performance panel by default on Beta

Categories

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

task

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1693316

People

(Reporter: Honza, Unassigned)

References

Details

The new Performance panel is enabled in Nightly be default (bug 1668218, Fx86) and DevEdition (bug 1693314, Fx 89). It should also be enabled in Beta when it's ready.

Honza

I believe we can't enable in Beta only, because Beta uses all the options and prefs we use for release, on purpose.
I believe we'll enable in Release (bug 1693316), but that will obviously ride the trains. In case we want to disable in Release before releasing, we'll provide a patch to disable the pref in the beta branch. But I doubt this will be necessary.

If that's OK with you, we can dupe to bug 1693316, what do you think?

Flags: needinfo?(odvarko)

You can put it behind the EARLY_BETA_OR_EARLIER flag (https://wiki.mozilla.org/Platform/Channel-specific_build_defines#EARLY_BETA_OR_EARLIER) so as to activate it on the Beta channel up to beta 6 (see https://fx-trains.herokuapp.com/release/?version=89). Later betas will have it deactivated and it won't ride to release.

I see, thanks Pascal!

I wonder if that's useful for us. What do y'all think?

I was thinking about safe path where we are enabling the panel step by step, but perhaps we don't need that...

If that's OK with you, we can dupe to bug 1693316, what do you think?

Yes, ok for me

Honza

Flags: needinfo?(odvarko)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE

(In reply to Julien Wajsberg [:julienw] from comment #3)

I see, thanks Pascal!

I wonder if that's useful for us. What do y'all think?

I think having users on the beta channel go back and forth between the old and new performance panel would be an unpleasant experience for them. So I would say we should go ahead and enable for beta+release once we think we are ready, and land a patch on the beta branch to pref off if we realize that something actually isn't ready.

You need to log in before you can comment on or make changes to this bug.