Closed Bug 1702144 Opened 4 years ago Closed 4 years ago

In private browsing the recently closed tabs/windows, clear history cannot be clicked

Categories

(Firefox :: Menus, defect, P2)

Product:
Firefox
Component:
Menus
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: rpopovici, Assigned: emmamalysz)

References

(Blocks 2 open bugs)

Details

(Keywords: regression, Whiteboard: [proton-hamburger-menu][priority:2a])

Attachments

(2 files)

2021-03-31_10h44_38.mp4
(deleted), video/mp4
Details
Bug 1702144, ensure recently closed tabs button is disabled when there are none
(deleted), text/x-phabricator-request
Details
Attached video 2021-03-31_10h44_38.mp4 (deleted) —

[Affected versions]
Beta 88
Nightly 89

[Affected platforms]
Win 10

[Precondition]
The following pref is set on true:

  • browser.proton.enabled

[Steps to reproduce]

  1. Open the Firefox browser
  2. Open 2 new windows and close them
  3. Reach the History submenu from the Hamburger menu
  4. Recently Closed windows is active and clickable
  5. Open a new private window
  6. Reach the History submenu from the Hamburger menu
  7. Close Private window
  8. Open again a new private window
  9. Reach again the History submenu from the Hamburger menu

Actual result:
The recently closed tabs/windows appears to be active and cannot be clicked. Please see screen recording.

Expected result:
Only Recently Closed window should be active and clickable. The recently closed tabs option should be greyed out(inactive)

Note: With preff off, the recently closed tabs/windows are clickable but are empty

status-firefox87: --- → unaffected
status-firefox88: --- → affected
status-firefox89: --- → affected
Whiteboard: [proton-hamburger-menu]
Blocks: 1702146
Blocks: proton-hamburger-menu, 1688173
No longer blocks: 1702146
Severity: -- → S2
Summary: In private browsing the recently closed tabs/windows, clear history cannot be clicked → Recently closed tabs and windows submenus lose functionality in a private window
Summary: Recently closed tabs and windows submenus lose functionality in a private window → In private browsing the recently closed tabs/windows, clear history cannot be clicked
Has Regression Range: --- → yes
Has STR: --- → yes

Romain, could please set the priority for this bug when you get a chance? This is a S2 from our perspective..
Thanks!

Flags: needinfo?(rtestard)
Flags: needinfo?(rtestard)
Priority: -- → P2
Whiteboard: [proton-hamburger-menu] → [proton-hamburger-menu][priority:2a]
Assignee: nobody → emalysz
Status: NEW → ASSIGNED

Removes macos rule that overrides disabled css rules
Removes early return to ensure the menu is created correctly

Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c828725294d2 ensure recently closed tabs button is disabled when there are none r=Gijs

https://hg.mozilla.org/mozilla-central/rev/c828725294d2

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified - Fixed in latest Nightly 89.0a1 (2021-04-19) with proton pref on, using Windows 10x64 and Mac 11.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: