Closed Bug 1702200 Opened 4 years ago Closed 3 years ago

Recently Closed Tabs/Windows toolbar separator disappears when the user access the submenu for the second time

Categories

(Firefox :: Menus, defect, P2)

defect

Tracking

()

VERIFIED FIXED
93 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- wontfix
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- wontfix
firefox91 --- wontfix
firefox92 --- wontfix
firefox93 --- verified

People

(Reporter: ailea, Assigned: mkohler)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [proton-hamburger-menu] [priority:2c])

Attachments

(2 files)

Attached video 2021-03-31_15h05_10.mp4 (deleted) —

Tested with:

Release 87
Beta 88.0b5
Nightly 89.0a1 (2021-03-31)

Tested on:

Windows 10
Windows 7 (Low Resolution)
MacOS 10.15

Preconditions:

In about:config, set browser.proton.enabled = true

Steps:

  1. Launch firefox and open some tabs.
  2. Close few tabs.
  3. Open the Hamburger Menu and go to History -> Recently Closed Tabs
  4. Close the hamburger Menu.
  5. Open the Hamburger Menu and go to History -> Recently Closed Tabs again.

Actual result:

The toolbar separator between "Recently Closed Tabs" header and the recently closed tabs list is not displayed anymore after the user access the "Recently Closed Tabs" submenu for the second time and it appears again only after a browser restart.

Expected result:

The toolbar separator between "Recently Closed Tabs" header and the recently closed tabs list should not disappear when the user access the submenu for the second time.

Note 1: This is reproducible also for the Recently Closed Windows.
Note 2: This is not reproducible without Proton pref enabled.

Priority: -- → P2
Whiteboard: [proton-hamburger-menu] → [proton-hamburger-menu] [priority:2c]

The toolbarseparator is added the first time a subview is opened. However for subsequent times the header already exists and we bailed out early without adding the separator.

Assignee: nobody → me
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/55776bb2f806 Add toolbarseparator when header already exist when showing subview r=mconley

Backed out changeset 55776bb2f806 (Bug 1702200) for causing failures in nsSocketTransport.
Backout link: https://hg.mozilla.org/integration/autoland/rev/aa4f9e45c77b990601611f7252f5097fd810a672
Push with failures, failure log.

Flags: needinfo?(me)
Flags: needinfo?(me)
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/27f4ee87599b Add toolbarseparator when header already exist when showing subview r=mconley
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Verified - Fixed in latest Beta 93.0b4 (build id: 20210912185727) and latest Nightly 94.0a1 (build id: 20210913213224).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: