Closed Bug 1702213 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28315 - font-stretch should use keywords for computed style when possible

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28315 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28315
Details from upstream follow.

b'Antoine Quint <graouts@apple.com>' wrote:

font-stretch should use keywords for computed style when possible

According to the css-fonts-4 definition for font-stretch:

For compatibility with [CSS-FONTS-3], getComputedStyle() serializes values that correspond to one of the font-stretch keywords as that keyword (instead of as a <percentage>).

Given that 150% matches extra-expanded and 75% matches condensed, these should be the expected values reported by the computed style in those tests.

Note that this makes this test fail in Firefox and Chrome which returns <percentage> in this case, while Safari will only pass the first of the two assertions.

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 185 subtests

Status Summary

Firefox

OK : 1
PASS: 184
FAIL: 1

Chrome

OK : 1
PASS: 184
FAIL: 1

Safari

OK : 1
PASS: 172
FAIL: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-fonts/animations/font-stretch-interpolation.html
An interpolation to inherit updates correctly on a parent style change.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0256e32fdaec [wpt PR 28315] - `font-stretch` should use keywords for computed style when possible, a=testonly https://hg.mozilla.org/integration/autoland/rev/4918bec2b7b6 [wpt PR 28315] - Update wpt metadata, a=testonly
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a16cf17f787 [wpt PR 28315] - `font-stretch` should use keywords for computed style when possible, a=testonly https://hg.mozilla.org/integration/autoland/rev/dd28d6a791c6 [wpt PR 28315] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d2e34d0d812 [wpt PR 28315] - `font-stretch` should use keywords for computed style when possible, a=testonly https://hg.mozilla.org/integration/autoland/rev/2b67f76dc50a [wpt PR 28315] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4108952a02f9 [wpt PR 28315] - `font-stretch` should use keywords for computed style when possible, a=testonly https://hg.mozilla.org/integration/autoland/rev/b509fe877f2e [wpt PR 28315] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4108952a02f9
https://hg.mozilla.org/mozilla-central/rev/b509fe877f2e

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.