Closed Bug 1702336 Opened 4 years ago Closed 4 years ago

Disable "signon.management.page.fileImport.enabled" for all channels

Categories

(Firefox :: about:logins, task, P1)

task

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox88 + verified
firefox89 + verified

People

(Reporter: tgiles, Assigned: tgiles)

References

Details

Attachments

(1 file)

Due to the various issues QA has found with the Login CSV import feature, the feature will be turned off until these issues are resolved.

Assignee: nobody → tgiles
Status: NEW → ASSIGNED
Priority: -- → P1
Severity: -- → N/A
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75221f284379 Disable Login CSV import feature for all channels. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Please request Beta approval on this ASAP.

Flags: needinfo?(tgiles)

Comment on attachment 9212934 [details]
Bug 1702336 - Disable Login CSV import feature for all channels. r=sfoster

Beta/Release Uplift Approval Request

  • User impact if declined: Login CSV import will stay enabled and could cause Firefox instability when importing a large amount of logins.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Patch is a pref-flip, should be low risk
  • String changes made/needed:
Attachment #9212934 - Flags: approval-mozilla-beta?
Flags: needinfo?(tgiles)

Comment on attachment 9212934 [details]
Bug 1702336 - Disable Login CSV import feature for all channels. r=sfoster

Approved for 88.0b6.

Attachment #9212934 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this issue using the latest Nightly 89.0a1 (Build ID: 20210401155139) and Firefox Beta 88.0b6 (Build ID: 20210401185811) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

  • The “signon.management.page.fileImport.enabled” pref is set to “false” value.

However, I have a question: Do we want this feature to be disabled in Nightly as well? I'm asking this because in the past in the Nighty builds the feature was enabled.

Status: RESOLVED → VERIFIED

I would say until we resolve Bug 1701660, we should keep this feature disabled in Nightly.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: