Closed Bug 1702343 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28322 - FSA: Make startIn field non-nullable

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox89 fixed)

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28322 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28322
Details from upstream follow.

b'Austin Sullivan <asully@chromium.org>' wrote:

FSA: Make startIn field non-nullable

Change this to match the spec.

There was not much reason to have this nullable in the first place,
since the startIn field is optional.

Bug: 1194652
Change-Id: I7e77945aceb11b554fc7952f22c8b4bde044880d
Reviewed-on: https://chromium-review.googlesource.com/2797570
WPT-Export-Revision: 023532eae5d2a4427230f3cab51e991976adfd20

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 69 subtests

Status Summary

Firefox

OK : 1
FAIL: 69

Chrome

OK : 1
PASS: 67
FAIL: 2

Safari

OK : 1
FAIL: 69

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/showPicker-errors.https.window.html
showOpenFilePicker: Showing a picker requires user activation.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: Showing a picker requires user activation.: FAIL (Chrome: PASS, Safari: FAIL)
showDirectoryPicker: Showing a picker requires user activation.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: File picker requires at least one accepted type.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't be an empty string.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type must have subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have empty type.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have empty subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have parameters.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have invalid characters in type.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have whitespace in the middle.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have invalid characters in subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: unknown well-known starting directory.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: starting directory can be null.: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: starting directory ID contains invalid characters.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: starting directory ID cannot exceed 32 characters.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".extensiontoolong". extension length more than 16..: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt.". extenstion ends with ".".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension "txt". extenstion does not start with ".".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".$txt". illegal character "$".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".t<xt". illegal character "<".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".t/xt". illegal character "".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ". xt". illegal character "/".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt". illegal characters "".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt?". illegal character "?".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt*". illegal character "".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".{txt". illegal character "{".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".}txt". illegal character "}".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension " .txt". illegal whitespace at front of extension.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ". txt". illegal whitespace in extension.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt ". illegal whitespace at end of extension.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".‮txt‮". illegal RTL character.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".tæxt". non-ASCII character "æ".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".קום". non-ASCII character "קום".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt🙂". non-ASCII character "🙂".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".{txt}". illegal characters "{" and "}".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: File picker requires at least one accepted type.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't be an empty string.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type must have subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have empty type.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have empty subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have parameters.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have invalid characters in type.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have whitespace in the middle.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have invalid characters in subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: unknown well-known starting directory.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: starting directory can be null.: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: starting directory ID contains invalid characters.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: starting directory ID cannot exceed 32 characters.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".extensiontoolong". extension length more than 16..: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt.". extenstion ends with ".".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension "txt". extenstion does not start with ".".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".$txt". illegal character "$".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".t<xt". illegal character "<".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".t/xt". illegal character "".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ". xt". illegal character "/".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt". illegal characters "".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt?". illegal character "?".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt". illegal character "*".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".{txt". illegal character "{".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".}txt". illegal character "}".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension " .txt". illegal whitespace at front of extension.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ". txt". illegal whitespace in extension.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt ". illegal whitespace at end of extension.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt". illegal RTL character.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".tæxt". non-ASCII character "æ".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".קום". non-ASCII character "קום".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt🙂". non-ASCII character "🙂".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".{txt}". illegal characters "{" and "}".: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c16e58dee39e [wpt PR 28322] - FSA: Make startIn field non-nullable, a=testonly https://hg.mozilla.org/integration/autoland/rev/d18ab91c3563 [wpt PR 28322] - Update wpt metadata, a=testonly
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4008943a0a01 [wpt PR 28322] - FSA: Make startIn field non-nullable, a=testonly https://hg.mozilla.org/integration/autoland/rev/94279bac2e03 [wpt PR 28322] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65a57f44189d [wpt PR 28322] - FSA: Make startIn field non-nullable, a=testonly https://hg.mozilla.org/integration/autoland/rev/771c6824518b [wpt PR 28322] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4808948cc975 [wpt PR 28322] - FSA: Make startIn field non-nullable, a=testonly https://hg.mozilla.org/integration/autoland/rev/b9c6a6eb5090 [wpt PR 28322] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4808948cc975
https://hg.mozilla.org/mozilla-central/rev/b9c6a6eb5090

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.