Closed Bug 1702431 Opened 4 years ago Closed 3 years ago

Remove per-platform findBar.css files after proton

Categories

(Toolkit :: Themes, task, P3)

Product:
Toolkit
Component:
Themes
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: ntim, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file)

Bug 1702431 - Remove per-platform findBar.css files. r?mconley
(deleted), text/x-phabricator-request
Details

After proton, with non-proton code removed, all 3 platforms will just include findBar.inc.css.

The shared findBar.inc.css should be renamed to findbar.css, and the platform specific files removed. jar.mn manifests should be updated accordingly.

Priority: -- → P3
Points: --- → 1
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39346118bd93 Remove per-platform findBar.css files. r=mconley

https://hg.mozilla.org/mozilla-central/rev/39346118bd93

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Backed out changeset 39346118bd93 (bug 1702431) for Browser-chrome failures in browser/components/preferences/tests/browser_open_download_preferences.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=343668791&repo=autoland&lineNumber=6670

Backout:
https://hg.mozilla.org/integration/autoland/rev/5474ceb3d02ddb49a5b7c4d5d11321feb7241966

Status: RESOLVED → REOPENED
status-firefox91: fixed → ---
Flags: needinfo?(mtigley)
Resolution: FIXED → ---
Target Milestone: 91 Branch → ---

I don't think this patch would have caused browser/components/preferences/tests/browser_open_download_preferences.js to fail since the changes here only involve removing / renaming the findbar stylesheets. Would you be able to check this again?

Flags: needinfo?(mtigley)
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f6c9c348681 Remove per-platform findBar.css files. r=mconley CLOSED TREE

https://hg.mozilla.org/mozilla-central/rev/1f6c9c348681

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: